-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Docs: Mention how to add new functionality without breaking APIs #8293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rdblue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
paliwalashish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This is very helpful
| If this is an acceptable break that will not harm your users, you can ignore it in future runs like so for: | ||
| * Just this break: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newbie question: If we introduce a new API, the CI shall flag it. How does it get handled during automated build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is handled the same way as on CI. revapi is being executed as part of the normal build, which then flags API/ABI-breaking changes
ConeyLiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks @nastra for the guideline.
|
thanks for the reviews everyone |
No description provided.