Skip to content

Conversation

@nastra
Copy link
Contributor

@nastra nastra commented Aug 11, 2023

No description provided.

@github-actions github-actions bot added the docs label Aug 11, 2023
Copy link
Contributor

@rdblue rdblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

Copy link

@paliwalashish paliwalashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
This is very helpful

If this is an acceptable break that will not harm your users, you can ignore it in future runs like so for:
* Just this break:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newbie question: If we introduce a new API, the CI shall flag it. How does it get handled during automated build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is handled the same way as on CI. revapi is being executed as part of the normal build, which then flags API/ABI-breaking changes

Copy link
Contributor

@ConeyLiu ConeyLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @nastra for the guideline.

@nastra nastra merged commit a3aff95 into master Aug 14, 2023
@nastra
Copy link
Contributor Author

nastra commented Aug 14, 2023

thanks for the reviews everyone

@nastra nastra deleted the revapi-example-avoid-breaking-apis branch August 14, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants