Skip to content

Conversation

@cabhishek
Copy link
Contributor

  • load_catalog API does not require the name of the catalog to be passed in as it can figure that out from ENV var or Config files.

Test code

from pyiceberg.catalog import load_catalog

catalog = load_catalog() # <- should load the default-catalog

catalog.list_namespaces()

Before PR

TypeError: load_catalog() missing 1 required positional argument: 'name'

After PR

Above code should load the default catalog and not throw any error.

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @cabhishek

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks @cabhishek

@Fokko Fokko added this to the PyIceberg 0.5.0 release milestone Aug 17, 2023
@Fokko
Copy link
Contributor

Fokko commented Aug 17, 2023

Merging this for the upcoming 0.5.0 release 🚀

@Fokko Fokko merged commit a2eb838 into apache:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants