Skip to content

Conversation

@wForget
Copy link
Member

@wForget wForget commented Sep 6, 2023

Similar to #2552, the NPE may also occur in the FastAppend#updateEvent method, and we should avoid it like that.

@github-actions github-actions bot added the core label Sep 6, 2023
@wForget
Copy link
Member Author

wForget commented Sep 6, 2023

BTW, why use ops.refresh().snapshot() instead of ops.current().snapshot() in MergingSnapshotProducer#updateEvent?

Snapshot justSaved = ops.refresh().snapshot(snapshotId);

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 17, 2024
@wForget wForget closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant