Skip to content

Conversation

@nk1506
Copy link
Contributor

@nk1506 nk1506 commented Oct 3, 2023

added missing docs for procedures publish_changes.
As per today this is the only procedure missing from doc.

Fixes #1601

@github-actions github-actions bot added the docs label Oct 3, 2023
@nk1506 nk1506 changed the title Docs: Document all stored procedures. Docs: Document publish_changes procedure Oct 3, 2023

### `publish_changes`

Publish changes from a Staged WAP id into the current table state.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Publish changes from a Staged WAP id into the current table state.
Publish changes from a staged WAP ID into the current table state.


#### Usage

| Argument Name | Required? | Type | Description |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra spaces and keep one trailing space.

For example, refer cherrypick_snapshot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for all the new tables

| Argument Name | Required? | Type | Description |
|---------------|-----------|------|-------------------------------------------------|
| `table` | ✔️ | string | Name of the table to update |
| `wap_id` | ✔️ | long | The wap_id to be pusblished from stage to prod. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove fullstop


#### Examples

publish_changes with wap_id 'wap_id_1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
publish_changes with wap_id 'wap_id_1'
publish_changes with WAP ID 'wap_id_1'

@ajantha-bhat ajantha-bhat requested a review from nastra October 4, 2023 05:16
@nk1506
Copy link
Contributor Author

nk1506 commented Oct 5, 2023

@nastra , please look.

@nastra nastra merged commit a960d43 into apache:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spark SQL Extensions: Document all stored procedures

3 participants