chore(server): Zero Copy Refactor Changes #1661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(sdk): PR Comments feat(sdk): Added stubs for Segment deletion feat(sdk): Add adjustments for segment deletion handling feat(sdk): Adjust error and const arguments feat(sdk): Merge Conflicts chore(repo): add ASF license header to all the files (apache#1627) Update all the existing files with the required ASF license header. Moreover, update the links in readme and cargo.toml files. chore(ci): change trigger event for release workflows (apache#1629) Replace trigger to tag push and add checks to verify if the tag name matches version set in corresponding Cargo.toml files. Skip docker publish steps in server release if not run as release (tag push) workflow. chore(ci): add new CI workflows for PR validation and testing (apache#1621) chore(repo): add Apache License Disclaimer, Notice (apache#1632) Co-authored-by: kparisa <kranti@apache.org> Co-authored-by: Piotr Gankiewicz <piotr.gankiewicz@gmail.com> feat(sdk): Add ASF license to src files feat(sdk): Add PR Adjustments and Integration Tests chore(ci): update envs for docker image release (apache#1633) Fix the names of envs used in workflow to publish the Iggy server image to DockerHub. chore(ci): allow docker workflow actions for each commit (apache#1637) Skip release conditions for docker steps in publish_server workflow in order to allow iggy docker image preparation for each merged commit under edge tag in dockerhub repo. chore(ci): add production workflow with Rust specific flow (apache#1642) Add production flow triggered on push to master branch with new Rust specific flow which triggers Docker image creation for x86_64 and aarch64 architectures with edge tag release to Docker Hub. fix(ci): pass DockerHub secrets to Rust production workflow (apache#1647) Pass DockerHub secrets from main production (on push) workflow to Rust workflow for creating images with iggy server. feat(sdk): Fix PR suggestions chore(ci): replace action which checks changed files (apache#1648) Replace GitHub Action which checks changed files with own implementation. Add scripts which implement checks which files has been changed in given pull requests. fix(ci): correct secret references in CI workflows (apache#1649) feat(bench): improve benchmark by parallelizing actors (apache#1645) This PR improves our benchmark suite, by parallelizing benchmark actors using `JoinSet` rather than `select` fix(ci): drop push by digest for edge tagged docker images (apache#1653) chore(ci): create combined edge tag for all docker images (apache#1654) fix(ci): fix artifact suffix to be unique for docker digests (apache#1655) chore(repo): add ASF license header to all the files (apache#1627) Update all the existing files with the required ASF license header. Moreover, update the links in readme and cargo.toml files. chore(ci): change trigger event for release workflows (apache#1629) Replace trigger to tag push and add checks to verify if the tag name matches version set in corresponding Cargo.toml files. Skip docker publish steps in server release if not run as release (tag push) workflow. chore(ci): add new CI workflows for PR validation and testing (apache#1621) chore(repo): add Apache License Disclaimer, Notice (apache#1632) Co-authored-by: kparisa <kranti@apache.org> Co-authored-by: Piotr Gankiewicz <piotr.gankiewicz@gmail.com> chore(ci): update envs for docker image release (apache#1633) Fix the names of envs used in workflow to publish the Iggy server image to DockerHub. chore(ci): allow docker workflow actions for each commit (apache#1637) Skip release conditions for docker steps in publish_server workflow in order to allow iggy docker image preparation for each merged commit under edge tag in dockerhub repo. chore(ci): add production workflow with Rust specific flow (apache#1642) Add production flow triggered on push to master branch with new Rust specific flow which triggers Docker image creation for x86_64 and aarch64 architectures with edge tag release to Docker Hub. fix(ci): pass DockerHub secrets to Rust production workflow (apache#1647) Pass DockerHub secrets from main production (on push) workflow to Rust workflow for creating images with iggy server. chore(ci): replace action which checks changed files (apache#1648) Replace GitHub Action which checks changed files with own implementation. Add scripts which implement checks which files has been changed in given pull requests. fix(ci): correct secret references in CI workflows (apache#1649) feat(bench): improve benchmark by parallelizing actors (apache#1645) This PR improves our benchmark suite, by parallelizing benchmark actors using `JoinSet` rather than `select` fix(ci): drop push by digest for edge tagged docker images (apache#1653) chore(ci): create combined edge tag for all docker images (apache#1654) fix(ci): fix artifact suffix to be unique for docker digests (apache#1655) fix(ci): Fixed CLI tests
Author
|
Had to add a few more files from the previous commits as there were missing dependencies @hubcio |
hubcio
reviewed
Mar 22, 2025
| Self: Sized; | ||
|
|
||
| /// Write the struct to a buffer. | ||
| fn write_to_buffer(&self, _buf: &mut BytesMut) { |
Contributor
There was a problem hiding this comment.
what is reason for porting this? it exist on much newer commit in zero-copy-no-batching branch, and the aim for this task was to port only changes related to ServerCommandHandler
hubcio
reviewed
Mar 22, 2025
| figment = { version = "0.10.19", features = ["toml", "env"] } | ||
| flume = "0.11.1" | ||
| futures = "0.3.31" | ||
| gxhash = "3.5.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR serves to port over the changes from branch zero-copy-no-batch commit ab12922.
Issue
#1658