Closed
Conversation
Author
|
Hi @chiradip, would you like to take a look at this PR? |
Contributor
|
Thanks for the PR, but we've decided to close down the #2208 issue, as it's unclear whether we want to pursue this path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Guidelines
Related to issue-2208
🙌 Thank you for contributing to
iggy!To help us incorporate your changes efficiently, please adhere to the following guidelines:
General Coding Remarks
cargo fmtto ensure your code adheres to the project's style.cargo clippy --all-targets --all-features -- -D warningsto make sure your code is lint-free.iggyproject's structure and coding style.cargo macheteto make sure no unused dependencies made their way into your changeset.cargo sort --workspaceso that the content of the toml files stay ordered.Commit Message Rules
Remember: Your contribution is essential to the success of
iggy. Please ensure that your PR conforms to these guidelines for a swift and smooth integration process.Thank you!