-
Notifications
You must be signed in to change notification settings - Fork 257
refactor(connectors): split connectors configs from the runtime config #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
09e0412 to
67efc32
Compare
|
Looks good overall! Just wondering, what if someone provides the same path for both, sink and source configs directory? Can we ensure, that it will also work? |
It doesn't work with the current implementation. In such a case, each config is imported as both source and sink. In theory, if the connector binary implements both traits, then it should work, but the configuration would be shared. I think this is an unusual case. |
fc0b4d2 to
cc78d38
Compare
cc78d38 to
cb88ca5
Compare
spetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Maybe let's also update the README for connectors runtime, with the new config_dir setting under " minimal viable configuration" info.
cb88ca5 to
59aaa9f
Compare
No description provided.