Skip to content

Conversation

@mmodzelewski
Copy link
Member

No description provided.

@mmodzelewski mmodzelewski force-pushed the connectors_config branch 2 times, most recently from 09e0412 to 67efc32 Compare November 7, 2025 13:37
@spetz
Copy link
Contributor

spetz commented Nov 7, 2025

Looks good overall! Just wondering, what if someone provides the same path for both, sink and source configs directory? Can we ensure, that it will also work?

@mmodzelewski
Copy link
Member Author

Looks good overall! Just wondering, what if someone provides the same path for both, sink and source configs directory? Can we ensure, that it will also work?

It doesn't work with the current implementation. In such a case, each config is imported as both source and sink. In theory, if the connector binary implements both traits, then it should work, but the configuration would be shared. I think this is an unusual case.
If you think it should work under one dir, then probably I'll need to introduce some discriminator value to the config file itself or rely on a configuration file name convention, e.g. quickwit.sink.toml, random.source.toml

@mmodzelewski mmodzelewski force-pushed the connectors_config branch 4 times, most recently from fc0b4d2 to cc78d38 Compare November 8, 2025 09:50
@mmodzelewski mmodzelewski marked this pull request as ready for review November 8, 2025 09:55
@mmodzelewski mmodzelewski requested a review from spetz November 8, 2025 09:56
Copy link
Contributor

@spetz spetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Maybe let's also update the README for connectors runtime, with the new config_dir setting under " minimal viable configuration" info.

@spetz spetz merged commit e0322b2 into master Nov 8, 2025
28 checks passed
@spetz spetz deleted the connectors_config branch November 8, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split connectors (sinks/sources) configuration from the connectors runtime configuration

3 participants