fix(server): fix consumer group leave race and append_messages#2521
Merged
fix(server): fix consumer group leave race and append_messages#2521
Conversation
hubcio
previously approved these changes
Dec 29, 2025
numinnex
force-pushed
the
fix_consumer_group_leave_and_append_messages
branch
from
3dfe2ba to
40e4af8
Compare
hubcio
approved these changes
Dec 29, 2025
mmodzelewski
approved these changes
Dec 29, 2025
spetz
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an race condition when client leaves consumer group, members collection was in inconsistent state, leading to panic on the
removemethod call.Additionally fixes an concurrency issue affecting
current_positionpointer in active segment, leading to incorrect indexes being written to disk. The scenario only happen in cases when every requestappend_messagesfrom the client triggered commit of the journal and disk store.