Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ github:
io_uring_tpc:
required_pull_request_reviews:
dismiss_stale_reviews: true
required_approving_review_count: 1
required_approving_review_count: 1
required_conversation_resolution: true
custom_subjects:
new_discussion: "{title}"
Expand Down
8 changes: 7 additions & 1 deletion .github/actions/rust/pre-merge/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,13 @@ runs:

- name: Build aarch64-musl
if: inputs.task == 'build-aarch64-musl'
run: cargo build --locked --target aarch64-unknown-linux-musl
# Exclude dashboard crates: charming's "ssr" feature pulls deno_core -> v8,
# which has no prebuilt binary for aarch64-unknown-linux-musl.
# TODO: support when upstream rusty_v8 publishes aarch64-musl binaries.
run: >-
cargo build --locked --workspace --target aarch64-unknown-linux-musl
--exclude iggy-bench-dashboard-server
--exclude bench-dashboard-frontend
shell: bash
env:
# Disable GCC outline atomics to avoid undefined __aarch64_ldadd4_sync
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/_build_rust_artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,16 @@ jobs:
export CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_LINKER=musl-gcc
fi

cargo build --locked --release --target ${{ matrix.target }} "${bin_flags[@]}"
# iggy-bench-dashboard-server enables charming's "ssr" feature (deno_core -> v8).
# v8 has no prebuilt binary for aarch64-unknown-linux-musl, so exclude dashboard
# crates to prevent cargo feature unification from pulling V8 into unrelated binaries.
# TODO: build V8 from source (V8_FROM_SOURCE=1, ~30min + clang) or wait for upstream support.
exclude_flags=()
if [[ "${{ matrix.target }}" == "aarch64-unknown-linux-musl" ]]; then
exclude_flags+=(--workspace --exclude iggy-bench-dashboard-server --exclude bench-dashboard-frontend)
fi

cargo build --locked --release --target ${{ matrix.target }} "${bin_flags[@]}" "${exclude_flags[@]}"

- name: Package binaries
id: pkg
Expand Down
Loading
Loading