test(java): add async-specific tests for ConsumerGroupsTcpClient#2890
Merged
mmodzelewski merged 3 commits intoapache:masterfrom Mar 10, 2026
Merged
test(java): add async-specific tests for ConsumerGroupsTcpClient#2890mmodzelewski merged 3 commits intoapache:masterfrom
mmodzelewski merged 3 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2890 +/- ##
============================================
+ Coverage 70.39% 70.44% +0.04%
- Complexity 772 776 +4
============================================
Files 1041 1041
Lines 86437 86437
Branches 62706 62707 +1
============================================
+ Hits 60850 60887 +37
+ Misses 23064 23029 -35
+ Partials 2523 2521 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mmodzelewski
approved these changes
Mar 10, 2026
hubcio
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2225
Rationale
The async
ConsumerGroupsTcpClienthad no dedicated test coverage. While the blocking client hadConsumerGroupsClientBaseTestandConsumerGroupsTcpClientTest, the async path only had a few scattered tests inside the monolithicAsyncClientIntegrationTest. Dedicated tests are needed to verify correctCompletableFuturesemantics.What changed?
The async consumer groups client had no focused test class, leaving join/leave, error propagation, and concurrent
CompletableFuturepatterns untested.Added
AsyncConsumerGroupsTest.javawith 17 tests covering all six API operations (create, get by id, get by name, list, delete by id, delete by name), join/leave membership including multi-client scenarios, error scenarios that assertIggyResourceNotFoundExceptionpropagates correctly throughExecutionException, andCompletableFuture-specific patterns such asthenComposechaining andallOfconcurrent operations.Local Execution
AI Usage
./gradlew :iggy:testconfirming 17/17 tests pass with 0 failures and no Netty resource leaks.