Skip to content

refactor(csharp): implement SDK version handling in login requests#2937

Merged
hubcio merged 3 commits intoapache:masterfrom
lukaszzborek:feature/dotnet-iggy-version
Mar 15, 2026
Merged

refactor(csharp): implement SDK version handling in login requests#2937
hubcio merged 3 commits intoapache:masterfrom
lukaszzborek:feature/dotnet-iggy-version

Conversation

@lukaszzborek
Copy link
Contributor

@lukaszzborek lukaszzborek commented Mar 15, 2026

  • change version passing during login from static value to assembly version
  • change PackageVersion attribute to Version in .csproj

PackageVersion attribute was changed because it is not visible in the assembly. If PackageVersion attribute is not set, Version attribute is used as the default.
Also I checked CI, and in all places, I see PackageVersion|Version check, so no need to change it

@lukaszzborek lukaszzborek linked an issue Mar 15, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.47%. Comparing base (ff4716e) to head (c0cd3ed).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
foreign/csharp/Iggy_SDK/Utils/SdkVersion.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2937      +/-   ##
============================================
- Coverage     70.28%   68.47%   -1.82%     
+ Complexity      862      729     -133     
============================================
  Files          1028     1052      +24     
  Lines         85280    84168    -1112     
  Branches      62656    60935    -1721     
============================================
- Hits          59940    57633    -2307     
- Misses        22828    24178    +1350     
+ Partials       2512     2357     -155     
Flag Coverage Δ
csharp 67.43% <85.71%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...DK/IggyClient/Implementations/HttpMessageStream.cs 71.72% <100.00%> (ø)
...SDK/IggyClient/Implementations/TcpMessageStream.cs 76.33% <100.00%> (ø)
foreign/csharp/Iggy_SDK/Utils/SdkVersion.cs 66.66% <66.66%> (ø)

... and 139 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio hubcio merged commit 6a6f155 into apache:master Mar 15, 2026
43 checks passed
@lukaszzborek lukaszzborek deleted the feature/dotnet-iggy-version branch March 15, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[csharp SDK] Implement SDK version handling in login requests

3 participants