refactor(csharp): implement SDK version handling in login requests#2937
Merged
hubcio merged 3 commits intoapache:masterfrom Mar 15, 2026
Merged
refactor(csharp): implement SDK version handling in login requests#2937hubcio merged 3 commits intoapache:masterfrom
hubcio merged 3 commits intoapache:masterfrom
Conversation
hubcio
reviewed
Mar 15, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2937 +/- ##
============================================
- Coverage 70.28% 68.47% -1.82%
+ Complexity 862 729 -133
============================================
Files 1028 1052 +24
Lines 85280 84168 -1112
Branches 62656 60935 -1721
============================================
- Hits 59940 57633 -2307
- Misses 22828 24178 +1350
+ Partials 2512 2357 -155
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hubcio
approved these changes
Mar 15, 2026
mmodzelewski
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PackageVersion attribute was changed because it is not visible in the assembly. If PackageVersion attribute is not set, Version attribute is used as the default.
Also I checked CI, and in all places, I see PackageVersion|Version check, so no need to change it