refactor(java): unify blocking TCP client as wrapper over async client#2947
Merged
mmodzelewski merged 4 commits intomasterfrom Mar 17, 2026
Merged
refactor(java): unify blocking TCP client as wrapper over async client#2947mmodzelewski merged 4 commits intomasterfrom
mmodzelewski merged 4 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2947 +/- ##
============================================
+ Coverage 70.25% 70.44% +0.19%
+ Complexity 925 909 -16
============================================
Files 1033 1029 -4
Lines 85665 84844 -821
Branches 63040 62427 -613
============================================
- Hits 60182 59772 -410
+ Misses 22982 22582 -400
+ Partials 2501 2490 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The blocking TCP client had its own independent protocol implementation via InternalTcpClient using Reactor Netty. This duplicated all serialization, request/response handling, and connection logic already present in the async client. Replace InternalTcpClient with thin delegation to AsyncIggyTcpClient, resolving CompletableFutures via FutureUtil.resolve(). This eliminates ~900 lines of duplicated protocol code and the Reactor dependency, replacing it with direct Netty modules.
d43791f to
ba29f6d
Compare
spetz
approved these changes
Mar 16, 2026
spetz
approved these changes
Mar 17, 2026
numinnex
approved these changes
Mar 17, 2026
hubcio
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blocking TCP client had its own independent protocol
implementation via InternalTcpClient using Reactor Netty.
This duplicated all serialization, request/response handling,
and connection logic already present in the async client.
Replace InternalTcpClient with thin delegation to
AsyncIggyTcpClient, resolving CompletableFutures via
FutureUtil.resolve(). This eliminates ~900 lines of
duplicated protocol code and the Reactor dependency,
replacing it with direct Netty modules.