fix(sdk): fix broken Windows build for SDK and CLI#2971
Merged
mmodzelewski merged 2 commits intomasterfrom Mar 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2971 +/- ##
============================================
- Coverage 71.99% 71.94% -0.05%
Complexity 925 925
============================================
Files 1113 1113
Lines 92345 92345
Branches 69893 69907 +14
============================================
- Hits 66482 66440 -42
- Misses 23304 23334 +30
- Partials 2559 2571 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The Rust SDK and CLI are cross-platform but were never compiled on Windows, allowing regressions to go undetected. iggy-server does not support Windows (it requires Linux io_uring), so only -p iggy -p iggy-cli are built. The posix_fadvise cfg guard was #[cfg(not(target_os = "macos"))], which is true on Windows. Since the nix crate is absent on Windows (unix-only dep), this caused an unresolved crate error. Changed to #[cfg(unix)]. The new build-windows-sdk task follows the same pattern as build-aarch64-gnu and build-macos-aarch64: listed in components.yml, routed to windows-latest in _test.yml, and handled in the pre-merge action. The disk cleanup step is guarded to Linux-only since it uses sudo and Linux-specific paths. Bumps iggy, iggy_common, iggy_binary_protocol to 0.9.3-edge.1 and iggy-cli to 0.11.3-edge.1.
ac01adc to
52fddfc
Compare
mmodzelewski
approved these changes
Mar 18, 2026
krishvishal
approved these changes
Mar 18, 2026
spetz
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust SDK and CLI are cross-platform but were never
compiled on Windows, allowing regressions to go
undetected. iggy-server does not support Windows (it
requires Linux io_uring), so only -p iggy -p iggy-cli
are built.
The posix_fadvise cfg guard was #[cfg(not(target_os =
"macos"))], which is true on Windows. Since the nix
crate is absent on Windows (unix-only dep), this caused
an unresolved crate error. Changed to #[cfg(unix)].
The new build-windows-sdk task follows the same pattern
as build-aarch64-gnu and build-macos-aarch64: listed in
components.yml, routed to windows-latest in _test.yml,
and handled in the pre-merge action. The disk cleanup
step is guarded to Linux-only since it uses sudo and
Linux-specific paths.
Bumps iggy, iggy_common, iggy_binary_protocol to
0.9.3-edge.1 and iggy-cli to 0.11.3-edge.1.
Refer to issue #2968.