Skip to content

fix(sdk): fix broken Windows build for SDK and CLI#2971

Merged
mmodzelewski merged 2 commits intomasterfrom
fix-windows-sdk-build
Mar 19, 2026
Merged

fix(sdk): fix broken Windows build for SDK and CLI#2971
mmodzelewski merged 2 commits intomasterfrom
fix-windows-sdk-build

Conversation

@hubcio
Copy link
Contributor

@hubcio hubcio commented Mar 18, 2026

The Rust SDK and CLI are cross-platform but were never
compiled on Windows, allowing regressions to go
undetected. iggy-server does not support Windows (it
requires Linux io_uring), so only -p iggy -p iggy-cli
are built.

The posix_fadvise cfg guard was #[cfg(not(target_os =
"macos"))], which is true on Windows. Since the nix
crate is absent on Windows (unix-only dep), this caused
an unresolved crate error. Changed to #[cfg(unix)].

The new build-windows-sdk task follows the same pattern
as build-aarch64-gnu and build-macos-aarch64: listed in
components.yml, routed to windows-latest in _test.yml,
and handled in the pre-merge action. The disk cleanup
step is guarded to Linux-only since it uses sudo and
Linux-specific paths.

Bumps iggy, iggy_common, iggy_binary_protocol to
0.9.3-edge.1 and iggy-cli to 0.11.3-edge.1.

Refer to issue #2968.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.94%. Comparing base (b45254f) to head (a7c67ce).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2971      +/-   ##
============================================
- Coverage     71.99%   71.94%   -0.05%     
  Complexity      925      925              
============================================
  Files          1113     1113              
  Lines         92345    92345              
  Branches      69893    69907      +14     
============================================
- Hits          66482    66440      -42     
- Misses        23304    23334      +30     
- Partials       2559     2571      +12     
Flag Coverage Δ
csharp 67.43% <ø> (-0.21%) ⬇️
go 36.38% <ø> (ø)
java 61.91% <ø> (ø)
node 91.37% <ø> (-0.07%) ⬇️
python 81.43% <ø> (ø)
rust 72.70% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ommon/src/types/segment_storage/messages_reader.rs 77.21% <ø> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The Rust SDK and CLI are cross-platform but were never
compiled on Windows, allowing regressions to go
undetected. iggy-server does not support Windows (it
requires Linux io_uring), so only -p iggy -p iggy-cli
are built.

The posix_fadvise cfg guard was #[cfg(not(target_os =
"macos"))], which is true on Windows. Since the nix
crate is absent on Windows (unix-only dep), this caused
an unresolved crate error. Changed to #[cfg(unix)].

The new build-windows-sdk task follows the same pattern
as build-aarch64-gnu and build-macos-aarch64: listed in
components.yml, routed to windows-latest in _test.yml,
and handled in the pre-merge action. The disk cleanup
step is guarded to Linux-only since it uses sudo and
Linux-specific paths.

Bumps iggy, iggy_common, iggy_binary_protocol to
0.9.3-edge.1 and iggy-cli to 0.11.3-edge.1.
@hubcio hubcio force-pushed the fix-windows-sdk-build branch from ac01adc to 52fddfc Compare March 18, 2026 13:40
@mmodzelewski mmodzelewski merged commit 34280ab into master Mar 19, 2026
78 checks passed
@mmodzelewski mmodzelewski deleted the fix-windows-sdk-build branch March 19, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants