feat(go): implement binary reader/writer#2986
Merged
hubcio merged 17 commits intoapache:masterfrom Mar 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2986 +/- ##
============================================
- Coverage 71.98% 71.89% -0.09%
Complexity 930 930
============================================
Files 1122 1120 -2
Lines 93496 93030 -466
Branches 71019 70377 -642
============================================
- Hits 67303 66888 -415
+ Misses 23623 23582 -41
+ Partials 2570 2560 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ryankert01
reviewed
Mar 20, 2026
hubcio
requested changes
Mar 21, 2026
47e3eb7 to
ea27dc3
Compare
Remove redundant comment about string reference.
This reverts commit e9d975d.
b052dbc to
4b454b5
Compare
4b454b5 to
669233f
Compare
hubcio
approved these changes
Mar 23, 2026
spetz
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale
Iggy, when read/write binary, use little endian. When there is a string, it has a prefix provide its length, and the actually string body. So instead of using the
binary.LittleEndian.Uint32(payload[processIDPos : processIDPos+4])and useposition ++, why not just wrap everything in a reader/writer to make it simple and clear.As the Stats deserialize function need to be updated, I think this change would be helpful. #2964 (comment)
Here is a example that shows the difference:
Before:
iggy/foreign/go/binary_serialization/stats_serializer.go
Lines 53 to 90 in 9c8b5cc
After
Example of writer
What changed?
A reader for byte slice is created.
Local Execution
AI Usage