fix(bench): delete stale streams on re-run to prevent corrupted latency#2991
Merged
fix(bench): delete stale streams on re-run to prevent corrupted latency#2991
Conversation
mmodzelewski
previously approved these changes
Mar 20, 2026
spetz
previously approved these changes
Mar 20, 2026
Consumers in ppc/bpcg/e2e/e2ecg read old messages from prior runs, producing garbage origin_timestamp latency. init_streams() now deletes existing streams before recreating them. Added --reuse-streams flag to opt into the old append behavior (used by integration tests).
hubcio
force-pushed
the
bench-improvement
branch
from
b5e38fa to
cfd6e52
Compare
numinnex
approved these changes
Mar 20, 2026
krishvishal
approved these changes
Mar 20, 2026
spetz
approved these changes
Mar 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2991 +/- ##
============================================
+ Coverage 71.86% 71.88% +0.01%
Complexity 930 930
============================================
Files 1117 1117
Lines 92952 92952
Branches 70472 70473 +1
============================================
+ Hits 66802 66816 +14
+ Misses 23590 23568 -22
- Partials 2560 2568 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers in ppc/bpcg/e2e/e2ecg read old messages from
prior runs, producing garbage origin_timestamp latency.
init_streams() now deletes existing streams before
recreating them.