Skip to content

fix(test): Fix Iceberg container readiness check to use HTTP health check#3077

Merged
mmodzelewski merged 1 commit intoapache:masterfrom
krishvishal:fix-iceberg-wait
Apr 6, 2026
Merged

fix(test): Fix Iceberg container readiness check to use HTTP health check#3077
mmodzelewski merged 1 commit intoapache:masterfrom
krishvishal:fix-iceberg-wait

Conversation

@krishvishal
Copy link
Copy Markdown
Contributor

Summary

  • Replace WaitFor::message_on_stderr("Started Server@") with WaitFor::http(HttpWaitStrategy) polling GET /v1/config on port 8181
  • Fixes all 3 failing Iceberg sink integration tests

Closes #3076

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.57%. Comparing base (7fca0f2) to head (1f66d96).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3077      +/-   ##
============================================
- Coverage     70.58%   70.57%   -0.01%     
  Complexity      943      943              
============================================
  Files          1113     1113              
  Lines         94590    94590              
  Branches      71790    71807      +17     
============================================
- Hits          66763    66760       -3     
+ Misses        25353    25336      -17     
- Partials       2474     2494      +20     
Components Coverage Δ
Rust Core 70.65% <ø> (+0.03%) ⬆️
Java SDK 62.30% <ø> (ø)
C# SDK 69.13% <ø> (-0.26%) ⬇️
Python SDK 81.43% <ø> (ø)
Node SDK 91.40% <ø> (-0.13%) ⬇️
Go SDK 38.97% <ø> (ø)
see 30 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmodzelewski mmodzelewski merged commit 5511798 into apache:master Apr 6, 2026
80 checks passed
@krishvishal krishvishal deleted the fix-iceberg-wait branch April 6, 2026 06:24
numinnex pushed a commit that referenced this pull request Apr 6, 2026
…alth check (#3079)

Closes #3078

## Summary
- Replace unreliable `WaitFor::message_on_stdout("started")` with
`HttpWaitStrategy` `on /_cluster/health`, matching the pattern from
#3077 (Iceberg fix)
- Remove redundant fixture health check loops in both sink and source
fixtures, since the container startup now guarantees ES is healthy
- Reduce excessive sleep durations and poll attempts in source tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iceberg sink integration tests fail due to container readiness check matching stale Jetty log format

3 participants