Conversation
Follow-up to #3124 plus review-round fixes on the release chain. Narrow cargo publish continue-on-error to the "already uploaded" class; capture stderr to a tempfile instead of a process-sub tee that raced the classifier. Make `commit` required in the rust publish reusable workflow and re-verify master-ancestry so direct workflow_call callers cannot bypass the check. Bring wait-for-crate curl up to wait-for-url parity and switch to `jq -Rr 'fromjson?'` so malformed NDJSON survives pipefail. Fail-fast on wrong-target tags; render them distinctly and keep rendering under skip_tag_creation=true, gating only exit 1. Cache cargo metadata once per job via \$GITHUB_ENV so the four post-merge composite Validate steps reuse it. Consolidate the pre-release vocabulary behind \`extract-version.sh --is-pre-release\` so post-merge.yml and publish.yml no longer diverge on \`.devN\` / bare \`rcN\`. Retune the idempotency pre-check to initial_sleep=1 and rewrite the two-layer wait comment with correct budgets (~8 min inner, ~28 min outer). Includes the Maven \`continue-on-error\` carve-out on publish.yml's Central wait step, rationale documented in-tree above the step.
mmodzelewski
approved these changes
Apr 14, 2026
spetz
approved these changes
Apr 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3125 +/- ##
============================================
- Coverage 72.74% 72.73% -0.01%
Complexity 943 943
============================================
Files 1117 1117
Lines 96368 96368
Branches 73541 73560 +19
============================================
- Hits 70100 70097 -3
+ Misses 23718 23703 -15
- Partials 2550 2568 +18
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3124 plus review-round fixes on the release chain.
Narrow cargo publish continue-on-error to the "already uploaded"
class; capture stderr to a tempfile instead of a process-sub tee
that raced the classifier. Make
commitrequired in the rustpublish reusable workflow and re-verify master-ancestry so direct
workflow_call callers cannot bypass the check. Bring wait-for-crate
curl up to wait-for-url parity and switch to
jq -Rr 'fromjson?'so malformed NDJSON survives pipefail. Fail-fast on wrong-target
tags; render them distinctly and keep rendering under
skip_tag_creation=true, gating only exit 1. Cache cargo metadata
once per job via $GITHUB_ENV so the four post-merge composite
Validate steps reuse it. Consolidate the pre-release vocabulary
behind `extract-version.sh --is-pre-release` so post-merge.yml and
publish.yml no longer diverge on `.devN` / bare `rcN`. Retune the
idempotency pre-check to initial_sleep=1 and rewrite the two-layer
wait comment with correct budgets (~8 min inner, ~28 min outer).
Includes the Maven `continue-on-error` carve-out on publish.yml's
Central wait step, rationale documented in-tree above the step.