Skip to content

fix(ci): harden publish pipeline#3125

Merged
spetz merged 1 commit intomasterfrom
ci-release-review-fixes
Apr 14, 2026
Merged

fix(ci): harden publish pipeline#3125
spetz merged 1 commit intomasterfrom
ci-release-review-fixes

Conversation

@hubcio
Copy link
Copy Markdown
Contributor

@hubcio hubcio commented Apr 14, 2026

Follow-up to #3124 plus review-round fixes on the release chain.

Narrow cargo publish continue-on-error to the "already uploaded"
class; capture stderr to a tempfile instead of a process-sub tee
that raced the classifier. Make commit required in the rust
publish reusable workflow and re-verify master-ancestry so direct
workflow_call callers cannot bypass the check. Bring wait-for-crate
curl up to wait-for-url parity and switch to jq -Rr 'fromjson?'
so malformed NDJSON survives pipefail. Fail-fast on wrong-target
tags; render them distinctly and keep rendering under
skip_tag_creation=true, gating only exit 1. Cache cargo metadata
once per job via $GITHUB_ENV so the four post-merge composite
Validate steps reuse it. Consolidate the pre-release vocabulary
behind `extract-version.sh --is-pre-release` so post-merge.yml and
publish.yml no longer diverge on `.devN` / bare `rcN`. Retune the
idempotency pre-check to initial_sleep=1 and rewrite the two-layer
wait comment with correct budgets (~8 min inner, ~28 min outer).
Includes the Maven `continue-on-error` carve-out on publish.yml's
Central wait step, rationale documented in-tree above the step.

Follow-up to #3124 plus review-round fixes on the release chain.

Narrow cargo publish continue-on-error to the "already uploaded"
class; capture stderr to a tempfile instead of a process-sub tee
that raced the classifier. Make `commit` required in the rust
publish reusable workflow and re-verify master-ancestry so direct
workflow_call callers cannot bypass the check. Bring wait-for-crate
curl up to wait-for-url parity and switch to `jq -Rr 'fromjson?'`
so malformed NDJSON survives pipefail. Fail-fast on wrong-target
tags; render them distinctly and keep rendering under
skip_tag_creation=true, gating only exit 1. Cache cargo metadata
once per job via \$GITHUB_ENV so the four post-merge composite
Validate steps reuse it. Consolidate the pre-release vocabulary
behind \`extract-version.sh --is-pre-release\` so post-merge.yml and
publish.yml no longer diverge on \`.devN\` / bare \`rcN\`. Retune the
idempotency pre-check to initial_sleep=1 and rewrite the two-layer
wait comment with correct budgets (~8 min inner, ~28 min outer).
Includes the Maven \`continue-on-error\` carve-out on publish.yml's
Central wait step, rationale documented in-tree above the step.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.73%. Comparing base (3e0c9e4) to head (4d9c5e1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3125      +/-   ##
============================================
- Coverage     72.74%   72.73%   -0.01%     
  Complexity      943      943              
============================================
  Files          1117     1117              
  Lines         96368    96368              
  Branches      73541    73560      +19     
============================================
- Hits          70100    70097       -3     
+ Misses        23718    23703      -15     
- Partials       2550     2568      +18     
Components Coverage Δ
Rust Core 73.49% <ø> (+<0.01%) ⬆️
Java SDK 62.30% <ø> (ø)
C# SDK 69.10% <ø> (-0.33%) ⬇️
Python SDK 81.43% <ø> (ø)
Node SDK 91.53% <ø> (+0.09%) ⬆️
Go SDK 39.41% <ø> (ø)
see 21 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spetz spetz merged commit 735e1fc into master Apr 14, 2026
81 checks passed
@spetz spetz deleted the ci-release-review-fixes branch April 14, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants