Skip to content

test(csharp): add leader_redirection scenario to BDD tests#3193

Merged
hubcio merged 7 commits into
apache:masterfrom
explise:test/csharp-bdd-leader-redirection-2628
May 1, 2026
Merged

test(csharp): add leader_redirection scenario to BDD tests#3193
hubcio merged 7 commits into
apache:masterfrom
explise:test/csharp-bdd-leader-redirection-2628

Conversation

@explise
Copy link
Copy Markdown
Contributor

@explise explise commented Apr 28, 2026

Which issue does this PR close?

Closes #2628

What changed?

Added leader redirection logic tests in C# sdk

Local Execution

  • Passed (5/5 scenarios green: 4 leader_redirection + 1 basic_messaging,
    against iggy-server on 8090 and a 2-node cluster on 8091/8092)
  • Pre-commit hooks (prek) ran

AI Usage

  1. Tool: Claude (Anthropic)
  2. Scope: porting the step file from bdd/rust/tests/steps/leader_redirection.rs
    to C#/Reqnroll, and diagnosing the Reqnroll MSBuild path-resolution issue
  3. Verified by running the BDD suite locally against a real iggy cluster
    built from source; all 5 scenarios pass and reproduce on a clean rebuild
  4. Yes — every line is reviewed and explainable

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (611fca0) to head (50b3923).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3193      +/-   ##
============================================
- Coverage     74.10%   74.07%   -0.03%     
  Complexity      943      943              
============================================
  Files          1159     1159              
  Lines        102033   102033              
  Branches      79083    79100      +17     
============================================
- Hits          75607    75580      -27     
- Misses        23765    23768       +3     
- Partials       2661     2685      +24     
Components Coverage Δ
Rust Core 75.31% <ø> (-0.02%) ⬇️
Java SDK 60.14% <ø> (ø)
C# SDK 69.07% <ø> (-0.31%) ⬇️
Python SDK 81.43% <ø> (ø)
Node SDK 91.53% <ø> (ø)
Go SDK 39.43% <ø> (ø)
see 20 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio
Copy link
Copy Markdown
Contributor

hubcio commented Apr 29, 2026

@lukaszzborek mind taking a look at this?

Copy link
Copy Markdown
Contributor

@lukaszzborek lukaszzborek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Also thanks for fixing multi build problem in bdd tests

@explise
Copy link
Copy Markdown
Contributor Author

explise commented May 1, 2026

@hubcio can u please review this, it has one approval and need one more for merge.

@hubcio hubcio merged commit 8425385 into apache:master May 1, 2026
50 checks passed
Standing-Man pushed a commit to Standing-Man/iggy that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[csharp SDK] Implement leader_redirection scenario in BDD tests

3 participants