feat(consensus): cache reply payload and notify subscriber on commit#3223
Merged
Conversation
3dac3e9 to
ff31ebd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3223 +/- ##
============================================
- Coverage 73.89% 73.82% -0.08%
Complexity 943 943
============================================
Files 1190 1193 +3
Lines 107988 108933 +945
Branches 85003 85968 +965
============================================
+ Hits 79801 80422 +621
- Misses 25452 25754 +302
- Partials 2735 2757 +22
🚀 New features to boost your workflow:
|
numinnex
requested changes
May 11, 2026
63b62c8 to
8baf5ea
Compare
numinnex
previously approved these changes
May 13, 2026
numinnex
approved these changes
May 14, 2026
mmodzelewski
approved these changes
May 14, 2026
spetz
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientTable(CachedReply, refcountedFrozenbuffer, Arc-bump on dedup) and deliver them to in-process subscribers via a oneshot channel embedded inPipelineEntry. Replaces the priorNotify`/pending-map indirection; awaiters no longer need a separate cache lookup after wakeup.ClientTableis metadata-only. Partition plane is at-least-once; consumers handle duplicates.EvictionHeader/EvictionReasonwire frame; typed reasons let the SDK trigger its eviction callback.prepare_queue(cap 8) plus a bufferedrequest_queue(cap 64).is_full()reports only the prepare queue so admission stays separate from drop-on-full backpressure. View-change reset cancels subscribers and clears the request queue; the prepare queue survives for DVC reconciliation.