Skip to content

ci(php): pin supported PHP version#3333

Merged
hubcio merged 5 commits into
apache:masterfrom
WaterWhisperer:php-pin-supported-version
May 29, 2026
Merged

ci(php): pin supported PHP version#3333
hubcio merged 5 commits into
apache:masterfrom
WaterWhisperer:php-pin-supported-version

Conversation

@WaterWhisperer
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #3305

Rationale

The PHP SDK action used distro/default PHP packages, so the tested PHP version could drift with runner image defaults.

What changed?

The PHP setup now installs explicit PHP 8.3 packages and exports the exact php8.3 / php-config8.3 binaries for later steps.

Local Execution

  • Passed
  • Pre-commit hooks ran

AI Usage

@github-actions
Copy link
Copy Markdown

Thanks for the pull request. It is now waiting for review, labeled S-waiting-on-review.

You can update that label as the review goes back and forth, with slash commands - each on its own line, in a regular PR comment (not an inline review reply):

  • /ready - mark it S-waiting-on-review again, after addressing feedback
  • /author - mark it S-waiting-on-author (maintainers, or anyone who has had a PR merged before)
  • /request-review @user ... - request reviewers (@user or @org/team)

Commands take up to ~90s to apply. If no reaction (👍 or 😕) appears on your comment, the apply step likely failed - check the repo's Actions tab for the PR Triage Apply run. Commands posted inside a review body (rather than a normal comment) cannot be reacted to, so they stay log-only.

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label May 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.64%. Comparing base (aa8b719) to head (40e3ae7).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3333      +/-   ##
============================================
+ Coverage     73.57%   73.64%   +0.07%     
  Complexity      943      943              
============================================
  Files          1222     1223       +1     
  Lines        114939   115710     +771     
  Branches      91676    92476     +800     
============================================
+ Hits          84561    85214     +653     
- Misses        27532    27590      +58     
- Partials       2846     2906      +60     
Components Coverage Δ
Rust Core 74.66% <ø> (+0.11%) ⬆️
Java SDK 58.44% <ø> (ø)
C# SDK 69.43% <ø> (-0.50%) ⬇️
Python SDK 81.06% <ø> (ø)
Node SDK 91.53% <ø> (ø)
Go SDK 40.20% <ø> (ø)
see 30 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio
Copy link
Copy Markdown
Contributor

hubcio commented May 28, 2026

@countradooku mind checking this?

@countradooku
Copy link
Copy Markdown
Contributor

countradooku commented May 28, 2026

@countradooku mind checking this?

I will check

@countradooku
Copy link
Copy Markdown
Contributor

@hubcio looks good to me

@hubcio hubcio merged commit 397533f into apache:master May 29, 2026
86 checks passed
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label May 29, 2026
@WaterWhisperer WaterWhisperer deleted the php-pin-supported-version branch May 29, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP SDK: pin supported PHP version in CI and package metadata

4 participants