IGNITE-17338 Implement RocksDB hash index storage #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashapolo
force-pushed
the
ignite-17338
branch
from
19ea030 to
3b68767
Compare
ibessonov
reviewed
Aug 23, 2022
...ge-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java
Outdated
Show resolved
Hide resolved
ibessonov
reviewed
Aug 23, 2022
| try (WriteOptions writeOptions = new WriteOptions().setDisableWAL(true)) { | ||
| // If we can't construct the range end prefix (nearly impossible case), we need to fallback to manually removing the data, | ||
| // since 'deleteRange' doesn't work without the upper bound. | ||
| if (rangeEnd == null) { |
Contributor
There was a problem hiding this comment.
I'd rather have an assertion that this is impossible. Partition id stops way before 0xffff.
By the way, have you updated the list of column families in RocksDbTableStorage#scheduleFlush? It's easy to miss, because I didn't document it :(
Contributor
Author
There was a problem hiding this comment.
By the way, have you updated the list of column families in RocksDbTableStorage#scheduleFlush
Wow, this is a very nice hint
ibessonov
approved these changes
Aug 24, 2022
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-17338