IGNITE-17701 Add common C++ utilities#1090
Merged
isapego merged 7 commits intoapache:mainfrom Sep 19, 2022
Merged
Conversation
isapego
approved these changes
Sep 16, 2022
Contributor
isapego
left a comment
isapego
left a comment
There was a problem hiding this comment.
Overall looks good. My concern though is that it won't compile on Windows and so I will need to implement Window versions of some functions from bits.
Comment on lines
+82
to
+84
| LITTLE = std::endian::little, | ||
| BIG = std::endian::big, | ||
| NATIVE = std::endian::native, |
Contributor
There was a problem hiding this comment.
std::endian is C++20 feature
Contributor
Author
There was a problem hiding this comment.
Yes, it's conditionally compiled. With a C++-20 compiler it should use standard constants otherwise it falls back to its own substitutes.
Contributor
Author
There was a problem hiding this comment.
I have just implemented a couple of functions for MS compiler. But I haven't checked that it actually works.
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.