IGNITE-17358 Metric exporters' configurations. #1098
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgusakov
force-pushed
the
ignite-17358
branch
from
b83ddd1 to
fbd3f4a
Compare
agura
approved these changes
Sep 20, 2022
...rc/main/java/org/apache/ignite/internal/metrics/configuration/MetricConfigurationModule.java
Outdated
Show resolved
Hide resolved
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManager.java
Outdated
Show resolved
Hide resolved
sk0x50
reviewed
Sep 26, 2022
...org/apache/ignite/internal/metrics/exporters/TestPullMetricsExporterConfigurationSchema.java
Outdated
Show resolved
Hide resolved
...org/apache/ignite/internal/metrics/exporters/TestPullMetricsExporterConfigurationSchema.java
Outdated
Show resolved
Hide resolved
...org/apache/ignite/internal/metrics/exporters/TestPushMetricsExporterConfigurationSchema.java
Outdated
Show resolved
Hide resolved
...org/apache/ignite/internal/metrics/exporters/TestPushMetricsExporterConfigurationSchema.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/metrics/configuration/MetricConfigurationModule.java
Outdated
Show resolved
Hide resolved
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManager.java
Outdated
Show resolved
Hide resolved
| private List<MetricExporter> metricExporters; | ||
| private Map<String, MetricExporter> availableExporters; | ||
|
|
||
| private MetricConfiguration metricConfiguration; |
Contributor
There was a problem hiding this comment.
In my understanding, at least this field should be volatile, because of we cannot guarantee that configure() and start() methods are called in the same thread or properly synchronized.
Contributor
Author
There was a problem hiding this comment.
configure and start has happens-before relations by design and must be called in sequence. Otherwise, we can start MetricManager with null configuration. In real code - IgniteImpl will do it
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManager.java
Outdated
Show resolved
Hide resolved
...rationTest/java/org/apache/ignite/internal/metrics/exporters/MetricExportersLoadingTest.java
Outdated
Show resolved
Hide resolved
...s/metrics/src/main/java/org/apache/ignite/internal/metrics/exporters/PushMetricExporter.java
Show resolved
Hide resolved
sk0x50
reviewed
Sep 26, 2022
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManager.java
Show resolved
Hide resolved
kgusakov
commented
Sep 26, 2022
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Slava Koptilin <slava.koptilin@gmail.com>
…ernal/metrics/exporters/TestPullMetricsExporterConfigurationSchema.java Co-authored-by: Slava Koptilin <slava.koptilin@gmail.com>
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.