IGNITE-17302 add the propagation of the maximal storages' lastAppliedIndex on onSnapshotSave#1263
Merged
tkalkirill merged 15 commits intoapache:mainfrom Oct 28, 2022
Merged
Conversation
…Index on onSnapshotSave
tkalkirill
reviewed
Oct 28, 2022
...table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java
Show resolved
Hide resolved
...table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java
Outdated
Show resolved
Hide resolved
tkalkirill
reviewed
Oct 28, 2022
...est/java/org/apache/ignite/internal/table/distributed/raft/PartitionCommandListenerTest.java
Show resolved
Hide resolved
...va/org/apache/ignite/internal/tx/storage/state/test/TestConcurrentHashMapTxStateStorage.java
Outdated
Show resolved
Hide resolved
sanpwc
reviewed
Oct 28, 2022
...table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java
Show resolved
Hide resolved
ibessonov
reviewed
Oct 28, 2022
...table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java
Show resolved
Hide resolved
...table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java
Show resolved
Hide resolved
Comment on lines
293
to
297
| // We need to take the max index here because otherwise there is a scenario on a node restart when a node will install | ||
| // snapshot instead of starting even if all data is presented. This might happen because a raft log is truncated up | ||
| // to the maximal index among storages after a snapshot is done in raft, | ||
| // and because we take minimal applied index among storages for the local recovery. In case of a cluster restart, | ||
| // it is possible that cluster even can't start, if we won't take max index. |
Contributor
There was a problem hiding this comment.
This is a very convoluted description, maybe even wrong partially, please change it. I don't think that mentioning leader (installing snapsho) is necessary here. This code is required for local recovery only and a possible scenario of false node failure when we actually have all required data
ibessonov
reviewed
Oct 28, 2022
...table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java
Outdated
Show resolved
Hide resolved
ibessonov
approved these changes
Oct 28, 2022
sanpwc
approved these changes
Oct 28, 2022
ivgag
pushed a commit
to unisonteam/ignite-3
that referenced
this pull request
Nov 4, 2022
…Index on onSnapshotSave (apache#1263)
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
…Index on onSnapshotSave (apache#1263)
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
…Index on onSnapshotSave (apache#1263)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-17302