IGNITE-18021 Creating an API for full rebalance without losing user data in MvPartitionStorage on receiver#1286
Merged
tkalkirill merged 8 commits intoapache:mainfrom Nov 2, 2022
Merged
Conversation
sashapolo
reviewed
Nov 1, 2022
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
...api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public void destroyPartition(int partitionId) throws StorageException { | ||
| Integer boxedPartitionId = partitionId; |
Contributor
There was a problem hiding this comment.
Why did you change this code?
Contributor
Author
There was a problem hiding this comment.
What is boxing for?
Contributor
There was a problem hiding this comment.
I would say it was a small (maybe useless optimization), but nevertheless, this change is not related to the PR and does not improve the code much
Contributor
Author
There was a problem hiding this comment.
This is a test code, such optimization is not needed, and it does not look very nice.
...ge-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestMvTableStorage.java
Outdated
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
...api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java
Outdated
Show resolved
Hide resolved
sashapolo
reviewed
Nov 2, 2022
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
...api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public void destroyPartition(int partitionId) throws StorageException { | ||
| Integer boxedPartitionId = partitionId; |
Contributor
There was a problem hiding this comment.
I would say it was a small (maybe useless optimization), but nevertheless, this change is not related to the PR and does not improve the code much
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Show resolved
Hide resolved
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvTableStorage.java
Outdated
Show resolved
Hide resolved
sashapolo
approved these changes
Nov 2, 2022
ivgag
pushed a commit
to unisonteam/ignite-3
that referenced
this pull request
Nov 4, 2022
…ata in MvPartitionStorage on receiver (apache#1286)
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
…ata in MvPartitionStorage on receiver (apache#1286)
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
…ata in MvPartitionStorage on receiver (apache#1286)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-18021