IGNITE-17590 C++ 3.0: Implement RecordBinaryView#1287
Merged
isapego merged 57 commits intoapache:mainfrom Nov 1, 2022
Merged
Conversation
ptupitsyn
reviewed
Nov 1, 2022
modules/platforms/cpp/ignite/client/detail/table/table_impl.cpp
Outdated
Show resolved
Hide resolved
| * @param value Value. | ||
| */ | ||
| template<typename T> | ||
| void set(std::string_view name, T&& value) { |
Contributor
There was a problem hiding this comment.
We have ignite_tuple_builder, but the tuple itself is also mutable? I think we should pick one:
- Builder + immutable Tuple with
to_buildermethod - Mutable Tuple without builder (used in Java and .NET clients)
| ignite_callback<std::vector<std::optional<value_type>>> callback) | ||
| { | ||
| if (keys.empty()) | ||
| throw ignite_error("At least one key should be supplied"); |
Contributor
There was a problem hiding this comment.
I think we should return empty vector when keys are empty. At least this is what Java and .NET APIs do. And it may save the user some extra checks.
The same applies to all multi-record operations.
ademakov
reviewed
Nov 1, 2022
ademakov
reviewed
Nov 1, 2022
| DATETIME = 14, /**< A timezone-free datetime encoded into 8 bytes as (date, time). */ | ||
| TIMESTAMP = 15, /**< Number of microseconds since Jan 1, 1970 00:00:00.000000 (with no | ||
| timezone) encoded into 10 bytes. */ | ||
| NUMBER = 16, /**< Variable-length integer number (optionally bound by n bytes in size). */ |
Contributor
There was a problem hiding this comment.
Do these explicit numbers have any significance?
Contributor
Author
There was a problem hiding this comment.
Yep, they are actually used in thin client protocol when we are retrieving table schemas from server.
isapego
requested review from
ademakov and
ptupitsyn
and removed request for
ademakov
ptupitsyn
approved these changes
Nov 1, 2022
slukyano
pushed a commit
to slukyano/ignite-3
that referenced
this pull request
Nov 1, 2022
slukyano
pushed a commit
to slukyano/ignite-3
that referenced
this pull request
Nov 1, 2022
ivgag
pushed a commit
to unisonteam/ignite-3
that referenced
this pull request
Nov 4, 2022
slukyano
pushed a commit
to slukyano/ignite-3
that referenced
this pull request
Nov 7, 2022
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Dec 26, 2024
Bumps `hadoop` from 3.4.0 to 3.4.1. Updates `org.apache.hadoop:hadoop-common` from 3.4.0 to 3.4.1 Updates `org.apache.hadoop:hadoop-mapreduce-client-core` from 3.4.0 to 3.4.1 Updates `org.apache.hadoop:hadoop-aws` from 3.4.0 to 3.4.1 --- updated-dependencies: - dependency-name: org.apache.hadoop:hadoop-common dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.hadoop:hadoop-mapreduce-client-core dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.hadoop:hadoop-aws dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: Aleksandr Polovtsev <alex.polovtcev@gmail.com> Co-authored-by: Aleksandr Polovtsev <alex.polovtcev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignite_tuple;record_view<ignite_tuple>;transaction) for future;removeinstead ofdeletein method names, asdeleteis reserved word in C++.