IGNITE-18015 Column's type mismatch error when inserting data into temporal columns with custom precision #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMashenkov
force-pushed
the
ignite-18015
branch
4 times, most recently
from
fa96cbf to
f1819db
Compare
zstan
reviewed
Nov 10, 2022
modules/table/src/test/java/org/apache/ignite/internal/table/MutableRowTupleAdapterTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
overall looks good, but i fill one comment plz fix it. |
korlov42
requested changes
Nov 10, 2022
Contributor
korlov42
left a comment
korlov42
left a comment
There was a problem hiding this comment.
It's OK to lose precision as in case of temporal types, but we definitely do not want to truncate customers data as in case of varlen types
AMashenkov
force-pushed
the
ignite-18015
branch
from
f1819db to
38f746b
Compare
zstan
reviewed
Nov 14, 2022
modules/table/src/test/java/org/apache/ignite/internal/table/MutableRowTupleAdapterTest.java
Outdated
Show resolved
Hide resolved
zstan
approved these changes
Nov 14, 2022
Contributor
zstan
left a comment
zstan
left a comment
There was a problem hiding this comment.
1 minor comment, overall LGTM
korlov42
approved these changes
Nov 14, 2022
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
…mporal columns with custom precision (apache#1323)
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
…mporal columns with custom precision (apache#1323)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.