IGNITE-18319 Pass sender consistendId instead of ClusterNode to handler #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibessonov
reviewed
Dec 6, 2022
modules/network-api/src/main/java/org/apache/ignite/network/MessagingService.java
Outdated
Show resolved
Hide resolved
| * Thrown when consistent ID cannot be resolved to a {@link ClusterNode} instance (i.e. when | ||
| * there is no node with such consistent ID in the physical topology). | ||
| */ | ||
| public class ConsistentIdNotResolvedException extends IgniteException { |
Contributor
There was a problem hiding this comment.
Maybe we should create proper error group and id for new exceptions that we create, otherwise we'll never migrate anything
Contributor
Author
There was a problem hiding this comment.
Added a group and error code, wired it in the exception constructor
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Dec 26, 2024
Add `ignite.error.handling.policy` config property with values: * `LOG_ONLY` - log and continue (default) * `STOP_TASK` - throw exception to Kafka, which can stop the task when `errors.tolerance` is `none` * `DEAD_LETTER_QUEUE` - pass failed items to `errantRecordReporter`, which sends them to the configured dead letter queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-18319