IGNITE-18027 Implementation of a full rebalance for RocksDbMvPartitionStorage on receiver#1530
Merged
tkalkirill merged 8 commits intoapache:mainfrom Jan 19, 2023
Merged
Conversation
sashapolo
reviewed
Jan 19, 2023
...ksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java
Outdated
Show resolved
Hide resolved
...ksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java
Show resolved
Hide resolved
...ksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java
Show resolved
Hide resolved
| } | ||
|
|
||
| // Changed storage states and expect all storage operations to stop soon. | ||
| busyLock.block(); |
Contributor
There was a problem hiding this comment.
Is it possible that a storage also gets stopped during a rebalance?
Contributor
Author
There was a problem hiding this comment.
Documentation for org.apache.ignite.internal.storage.MvPartitionStorage#close says:
<p>REQUIRED: For background tasks for partition, such as rebalancing, to be completed by the time the method is called.
Contributor
There was a problem hiding this comment.
Maybe we should have an assertion here? Otherwise we will simply stall
Contributor
Author
There was a problem hiding this comment.
No need, because at the beginning we are trying to change the state of the storage on line 1474.
...ksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/ignite/internal/storage/rocksdb/index/RocksDbHashIndexStorage.java
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/internal/storage/rocksdb/index/RocksDbSortedIndexStorage.java
Show resolved
Hide resolved
...ge-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java
Outdated
Show resolved
Hide resolved
...ge-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java
Outdated
Show resolved
Hide resolved
...ge-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java
Outdated
Show resolved
Hide resolved
sashapolo
approved these changes
Jan 19, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
…nStorage on receiver (apache#1530)
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
…nStorage on receiver (apache#1530)
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-18027