IGNITE-18358 IGN-TX-5 on concurrent transactional single key load#1563
Merged
vldpyatkov merged 5 commits intoapache:mainfrom Jan 27, 2023
Merged
IGNITE-18358 IGN-TX-5 on concurrent transactional single key load#1563vldpyatkov merged 5 commits intoapache:mainfrom
vldpyatkov merged 5 commits intoapache:mainfrom
Conversation
Comment on lines
268
to
270
|
|
||
| /** Failed to release a lock on a key. */ | ||
| public static final int RELEASE_LOCK_ERR = TX_ERR_GROUP.registerErrorCode(4); | ||
|
|
||
| /** Failed to acquire a lock on a key due to a conflict. */ | ||
| public static final int ACQUIRE_LOCK_ERR = TX_ERR_GROUP.registerErrorCode(5); | ||
|
|
Contributor
There was a problem hiding this comment.
shouldnt we descrease the numbers of ACQUIRE_LOCK_ERR and following codes?
| import static java.util.concurrent.CompletableFuture.completedFuture; | ||
| import static java.util.concurrent.CompletableFuture.failedFuture; | ||
| import static org.apache.ignite.internal.util.ExceptionUtils.withCause; | ||
| import static org.apache.ignite.lang.ErrorGroups.Common.UNKNOWN_ERR; |
Contributor
There was a problem hiding this comment.
why UNKNOWN_ERR is deprecated? im not sure that it is good pattern to use deprecated value, but if it is ok, the annotation should be removed
vldpyatkov
force-pushed
the
ignite-18358
branch
from
6ea728e to
0ed91bd
Compare
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-18358