IGNITE-18625 Sql. Code cleanup. Unmute tests. #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMashenkov
force-pushed
the
ignite-18625
branch
3 times, most recently
from
d5158fd to
5eb8aff
Compare
AMashenkov
force-pushed
the
ignite-18625
branch
from
5eb8aff to
a9548c4
Compare
AMashenkov
force-pushed
the
ignite-18625
branch
from
f54dab9 to
3b23f93
Compare
...les/runner/src/integrationTest/java/org/apache/ignite/internal/index/ItIndexManagerTest.java
Outdated
Show resolved
Hide resolved
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java
Show resolved
Hide resolved
AMashenkov
requested review from
ygerzhedovich and
zstan
and removed request for
ygerzhedovich
| } | ||
| }) | ||
| ).join(); | ||
| compPublisher.subscribe(new Subscriber<>() { |
Contributor
There was a problem hiding this comment.
please return back runAsync here, it requeres for the test
Member
Author
There was a problem hiding this comment.
I think all the guaranties are preserved.
Test thread would continue work (exit from join()) right after subscribe() method had been finished in background thread.
Now, test thread just continue after exiting from subscribe() method.
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.