IGNITE-16376: Sql. Add UUID custom data type. by lowka · Pull Request #1623 · apache/ignite-3

lowka · 2023-02-02T17:28:46Z

Adds UUID type.

ygerzhedovich · 2023-02-10T09:53:02Z

modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItUuidTest.java

+/**
+ * Tests for {@link org.apache.ignite.internal.sql.engine.type.UuidType} data type.
+ */
+public class ItUuidTest extends AbstractBasicIntegrationTest {


will e good to add tests with UUID as Primary Key

There are such tests in ItPublicApiColocationTest::colocationOneColumn

...-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexToLixTranslator.java

Adds UUID data type.

...ine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlToRelConvertor.java

…l/engine/prepare/IgniteSqlToRelConvertor.java Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com>

...es/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteCustomType.java

…l/engine/type/IgniteCustomType.java Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com>

fix checkstyle errors.

zstan · 2023-02-13T06:45:05Z

modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcDatabaseMetadata.java

                (short) typeNullable, false, (short) typeSearchable, false, false, false, "LONGVARBINARY", 0, 0,
                Types.LONGVARBINARY, 0, null));

+        types.add(Arrays.asList("UUID", Types.OTHER, ColumnMetadata.UNDEFINED_PRECISION, "'", "'", null,


seems we need additional test here ItJdbcMetadataSelfTest ?

modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItUuidTest.java

zstan · 2023-02-13T07:11:28Z

modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItUuidTest.java

+        assertQuery("SELECT ? = ?").withParams(uuid1, uuid2).returns(false).check();
+        assertQuery("SELECT ? != ?").withParams(uuid1, uuid2).returns(true).check();
+
+        assertQuery("SELECT ? > ?").withParams(uuid2, uuid1).returns(false).check();


Suggested change

assertQuery("SELECT ? > ?").withParams(uuid2, uuid1).returns(false).check();

assertQuery("SELECT ? > ?").withParams(uuid2, uuid1).returns(false).check();

assertQuery("SELECT ? > ?").withParams(uuid1, uuid2).returns(true).check();

I have added additional checks that include for_less then and less_then_or_equals operators.

modules/runner/src/integrationTest/java/org/apache/ignite/internal/sqllogic/ItSqlLogicTest.java

...sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexExecutorImpl.java

zstan · 2023-02-13T10:32:12Z

modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java

            return Period.of((Integer) val / 12, (Integer) val % 12, 0);
        } else if (storageType == byte[].class && val instanceof ByteString) {
            return ((ByteString) val).getBytes();
+        } else if (storageType == UUID.class) {


do we need it just for assertion check and if so - is assertion is enough here?

It is not sufficient because else branch is called for all other type/value combinations.
And if guard for UUID tests that a value of UUID data type is UUID and nothing else.

add jdbc tests.

uncomment test.

fix test.

fix jdbc test.

...s/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteTypeFactory.java

rename, comments.

+ binary comparison checks

typo.

fix comment.

...e/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java

modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcDatabaseMetadata.java

modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteResource.java

...es/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteCustomType.java

modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/UuidFunctions.java

modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItUuidTest.java

fix javadoc, add generic.

fix javadoc.

add custom type family

remove custom type family because it breaks casts.

Remove redundant method from IgniteResource.

Code style. check styles.

Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com> Co-authored-by: korlov42 <korlov@gridgain.com>

lowka force-pushed the ignite-16376 branch 17 times, most recently from f957df4 to 559e02f Compare February 8, 2023 16:44

lowka marked this pull request as ready for review February 9, 2023 11:28

ygerzhedovich reviewed Feb 10, 2023

View reviewed changes

...-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexToLixTranslator.java Outdated Show resolved Hide resolved

IGNITE-16376: Investigate of support additional data types in Calcite.

9e17544

Adds UUID data type.

AMashenkov reviewed Feb 10, 2023

View reviewed changes

...ine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlToRelConvertor.java Outdated Show resolved Hide resolved

IGNITE-16376: Investigate of support additional data types in Calcite.

a349aa2

lowka force-pushed the ignite-16376 branch from a201c96 to a349aa2 Compare February 10, 2023 13:24

lowka and others added 3 commits February 10, 2023 17:27

IGNITE-16376: Investigate of support additional data types in Calcite.

db6025c

IGNITE-16376: Investigate of support additional data types in Calcite.

70950d6

Update modules/sql-engine/src/main/java/org/apache/ignite/internal/sq…

b1f47ea

…l/engine/prepare/IgniteSqlToRelConvertor.java Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com>

AMashenkov reviewed Feb 10, 2023

View reviewed changes

...es/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteCustomType.java Outdated Show resolved Hide resolved

Update modules/sql-engine/src/main/java/org/apache/ignite/internal/sq…

05535b6

…l/engine/type/IgniteCustomType.java Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com>

AMashenkov changed the title ~~IGNITE-16376: Investigate of support additional data types in Calcite.~~ IGNITE-16376: Investigate of support additional data types in Calcite Feb 10, 2023

IGNITE-16376: Investigate of support additional data types in Calcite.

7af9ee1

fix checkstyle errors.

zstan reviewed Feb 13, 2023

View reviewed changes

lowka added 5 commits February 13, 2023 15:54

IGNITE-16376: Investigate of support additional data types in Calcite.

e41c4ee

add jdbc tests.

IGNITE-16376: Investigate of support additional data types in Calcite.

e820d2e

uncomment test.

IGNITE-16376: Investigate of support additional data types in Calcite.

c35a347

fix test.

IGNITE-16376: Investigate of support additional data types in Calcite.

9e7d52a

fix jdbc test.

Merge branch 'main' into ignite-16376

c2724f4

AMashenkov requested changes Feb 14, 2023

View reviewed changes

lowka added 4 commits February 14, 2023 14:52

IGNITE-16376: Investigate of support additional data types in Calcite.

3382e8e

rename, comments.

IGNITE-16376: Investigate of support additional data types in Calcite.

ac57ebd

+ binary comparison checks

IGNITE-16376: Investigate of support additional data types in Calcite.

2b2c19c

typo.

IGNITE-16376: Investigate of support additional data types in Calcite.

1d782bb

fix comment.

korlov42 reviewed Feb 14, 2023

View reviewed changes

lowka and others added 10 commits February 14, 2023 23:50

IGNITE-16376: Investigate of support additional data types in Calcite.

7315b58

fix javadoc, add generic.

IGNITE-16376: Investigate of support additional data types in Calcite.

21efcbb

fix javadoc.

IGNITE-16376: Investigate of support additional data types in Calcite.

f2a9b0d

fix javadoc.

IGNITE-16376: Investigate of support additional data types in Calcite.

f9023ff

fix javadoc.

IGNITE-16376: Investigate of support additional data types in Calcite.

bf5ac65

add custom type family

IGNITE-16376: Investigate of support additional data types in Calcite.

05099fa

remove custom type family because it breaks casts.

IGNITE-16376: Investigate of support additional data types in Calcite.

3f8e813

Remove redundant method from IgniteResource.

IGNITE-16376: Investigate of support additional data types in Calcite.

3e3b206

Code style. check styles.

fix some styles

b2c44ab

Merge remote-tracking branch 'origin/main' into ignite-16376

52cc635

AMashenkov approved these changes Feb 16, 2023

View reviewed changes

korlov42 approved these changes Feb 16, 2023

View reviewed changes

lowka changed the title ~~IGNITE-16376: Investigate of support additional data types in Calcite~~ IGNITE-16376: Sql. Add UUID custom data type. Feb 16, 2023

korlov42 merged commit 5918d4e into apache:main Feb 16, 2023

korlov42 deleted the ignite-16376 branch February 16, 2023 09:54

lowka added a commit to gridgain/apache-ignite-3 that referenced this pull request Mar 18, 2023

IGNITE-16376: Sql. Add UUID custom data type. (apache#1623)

0aed5f4

Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com> Co-authored-by: korlov42 <korlov@gridgain.com>

lowka added a commit to gridgain/apache-ignite-3 that referenced this pull request Apr 19, 2023

IGNITE-16376: Sql. Add UUID custom data type. (apache#1623)

a353f07

Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com> Co-authored-by: korlov42 <korlov@gridgain.com>

Conversation

lowka commented Feb 2, 2023

Uh oh!

ygerzhedovich Feb 10, 2023

Choose a reason for hiding this comment

Uh oh!

lowka Feb 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zstan Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

lowka Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zstan Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

lowka Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

lowka Feb 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zstan Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

lowka Feb 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lowka Feb 10, 2023 •

edited

Loading

lowka Feb 13, 2023 •

edited

Loading