IGNITE-18479: ports #1629
Merged
IGNITE-18479: ports #1629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith-limit physical relational operator
…ation of complex expressions in index conditions
ygerzhedovich
force-pushed
the
ignite-18479
branch
from
1309ddb to
bc58827
Compare
lowka
reviewed
Feb 22, 2023
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/IgniteSort.java
Outdated
Show resolved
Hide resolved
...s/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/SortConverterRule.java
Outdated
Show resolved
Hide resolved
ygerzhedovich
force-pushed
the
ignite-18479
branch
2 times, most recently
from
b10ff68 to
d7157e1
Compare
…r port IGNITE-16013
ygerzhedovich
force-pushed
the
ignite-18479
branch
from
d7157e1 to
b569fbb
Compare
lowka
approved these changes
Feb 22, 2023
AMashenkov
reviewed
Feb 22, 2023
...s/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java
Show resolved
Hide resolved
AMashenkov
approved these changes
Feb 22, 2023
AMashenkov
reviewed
Feb 22, 2023
Comment on lines
+49
to
+50
| /** Reverse-ordered rows in case of limited sort. */ | ||
| private List<RowT> reversed; |
Member
There was a problem hiding this comment.
Suggested change
| /** Reverse-ordered rows in case of limited sort. */ | |
| private List<RowT> reversed; | |
| /** Reverse-ordered rows in case of limited sort. */ | |
| private List<RowT> stack; |
Also, I'd use fastutil Stack interface here, or even add Stack backed by ArrayList to core module.
Member
There was a problem hiding this comment.
Also, I think we can reuse the same array for both structures: PriorityQueue and Stack.
E.g. using ObjectHeapPriorityQueue and write trivial Stack implementation.
Actually, PriorityQueue stores data in heap structure that is partially sorted.
It looks easy to implement heap-sort algorithm to get the array sorted instantly.
Contributor
Author
There was a problem hiding this comment.
I think most optimizations and refactoring should be done separately. Here just port from AI2 with fixes real bugs
…r port IGNITE-16013
ygerzhedovich
force-pushed
the
ignite-18479
branch
from
c29b50b to
6684da0
Compare
# Conflicts: # modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/Accumulators.java
ygerzhedovich
force-pushed
the
ignite-18479
branch
from
ee7d4a5 to
7c0b152
Compare
lowka
approved these changes
Feb 23, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.