IGNITE-18609 .NET: Add ContainsKey method to Record API #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isapego
approved these changes
Feb 6, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
* `IRecordView` does not have `Contains`, and `KeyValueView` has one. Add the missing method. * Use `ContainsKey` name to stress the fact that only key part of the record is checked (which is evident from the signature in `KeyValueView`, but not in `RecordView`).
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
* `IRecordView` does not have `Contains`, and `KeyValueView` has one. Add the missing method. * Use `ContainsKey` name to stress the fact that only key part of the record is checked (which is evident from the signature in `KeyValueView`, but not in `RecordView`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRecordViewdoes not haveContains, andKeyValueViewhas one. Add the missing method.ContainsKeyname to stress the fact that only key part of the record is checked (which is evident from the signature inKeyValueView, but not inRecordView).