IGNITE-17056 Design for rebalance cancellation #1676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgusakov
force-pushed
the
ignite-17056
branch
from
04bbc45 to
aa82437
Compare
kgusakov
force-pushed
the
ignite-17056
branch
from
aa82437 to
a367daf
Compare
denis-chudov
suggested changes
Feb 20, 2023
| - On every new PD leader elected - it must check the direct value (not the locally cached one) of `zoneId.assignment.pending` keys and send RebalanceRequest to needed PrimaryReplicas and then listen updates from the last revision. | ||
| - On every PrimaryReplica reelection by PD it must send the new RebalanceRequest to PrimaryReplica, if pending key is not empty. | ||
| - On every leader reelection (for the leader oriented protocols) inside the replication group - leader send leaderElected event to PrimaryReplica, which force PrimaryReplica to send RebalanceRequest to the replication group leader again. | ||
| - On every new PD leader elected - it must check the direct value (not the locally cached one) of `zoneId.assignment.pending`/`zondeId.assignment.cancel` (the last one always wins, if exists) keys and send `RebalanceRequest`/`CancelRebalanceRequest` to needed PrimaryReplicas and then listen updates from the last revision of this key. |
Contributor
There was a problem hiding this comment.
Do these requests contain revision? Only old and new topology is mentioned, as I can see
| When PrimaryReplica send `CancelRebalanceRequest(oldTopology, newTopology)` to the ReplicationGroup following cases available: | ||
| - Replication group has ongoing rebalance oldToplogy->newTopology. So, it must be cancelled and cleanup for the configuration state of replication group to oldTopology must be executed. | ||
| - Replication group has no ongoing rebalance and currentTopology==oldTopology. So, nothing to cancel, return success response. | ||
| - Replication group has no ongoing rebalance and currentTopology==newTopology. So, cancel request can't be executed, return the response about it. Result recipient of this response (placement driver) must log this fact and do the same routine for usual rebalanceDone. |
Contributor
There was a problem hiding this comment.
What if after sending CancelRebalanceRequest the placement driver finds out that some of replication groups have finished rebalance (currentTopology==newTopology) and some have not?
Contributor
Author
There was a problem hiding this comment.
How does it possible, if any rebalance touches only one distribution zone, so, only one replication group?
Contributor
There was a problem hiding this comment.
Seems I missed this moment, my fault. Question withdrawn.
Co-authored-by: Denis Chudov <moonglloom@gmail.com>
denis-chudov
suggested changes
Feb 22, 2023
Co-authored-by: Denis Chudov <moonglloom@gmail.com>
denis-chudov
approved these changes
Feb 22, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
…pache#1676 Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
…pache#1676 Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-17056