IGNITE-18814 Fix ItTxDistributedTestSingleNode#assertPartitionsSame #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alievmirza
reviewed
Feb 22, 2023
| if (hash == 0) { | ||
| hash = storage.hashCode(); | ||
| } else if (hash != storage.hashCode()) { | ||
| if (storageIdx == 0) { |
Contributor
There was a problem hiding this comment.
Please add todo here that we need to change the way how we compare partitions after consistency checker feature will be implemented https://issues.apache.org/jira/browse/IGNITE-18869
And please, add comment to the epic that we have this todo, so we couldn't forget to fix this place
Contributor
Author
There was a problem hiding this comment.
I added the todo in a summary of the method.
alievmirza
reviewed
Feb 22, 2023
...le/src/integrationTest/java/org/apache/ignite/distributed/ItTxDistributedTestSingleNode.java
Outdated
Show resolved
Hide resolved
alievmirza
approved these changes
Feb 22, 2023
…ibuted/ItTxDistributedTestSingleNode.java Co-authored-by: Mirza Aliev <alievmirza@gmail.com>
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-18814