IGNITE-18895 Implement a background GC process #1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibessonov
reviewed
Mar 1, 2023
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
Show resolved
Hide resolved
| ).join(); | ||
| mvGc.removeStorage(tablePartitionId) | ||
| .thenCompose(unused -> allOf( | ||
| internalTable.storage().destroyPartition(partitionId), |
Contributor
There was a problem hiding this comment.
I hope one day we will refactor all this spaghetti code and extract proper abstractions :(
Contributor
Author
There was a problem hiding this comment.
Of course, in a brave new future!
| class GcStorageHandler { | ||
| final StorageUpdateHandler storageUpdateHandler; | ||
|
|
||
| final AtomicReference<CompletableFuture<Void>> gcInProgressFuture = new AtomicReference<>(); |
Contributor
There was a problem hiding this comment.
Can you please document fields as well?
Contributor
There was a problem hiding this comment.
Also, why have you decided to go with default field visibility instead of encapsulating the logic inside of methods, like it's usually done almost everywhere?
Contributor
Author
There was a problem hiding this comment.
Tried adding documentation. This class is just a container and is used only inside the package, why complicate the code?
Contributor
There was a problem hiding this comment.
Why complicate the code - to make it clearer I guess, encapsulation exists for reasons
Contributor
Author
There was a problem hiding this comment.
This class is package-private, why should we complicate the code?
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/gc/MvGc.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/gc/MvGc.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/gc/MvGc.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/gc/MvGc.java
Outdated
Show resolved
Hide resolved
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/gc/MvGcTest.java
Outdated
Show resolved
Hide resolved
ibessonov
reviewed
Mar 2, 2023
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
Outdated
Show resolved
Hide resolved
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
Outdated
Show resolved
Hide resolved
ibessonov
approved these changes
Mar 2, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Feb 4, 2025
Bumps [io.grpc:protoc-gen-grpc-java](https://github.com/grpc/grpc-java) from 1.69.0 to 1.70.0. - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.69.0...v1.70.0) --- updated-dependencies: - dependency-name: io.grpc:protoc-gen-grpc-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: Aleksandr Polovtsev <alex.polovtcev@gmail.com> Co-authored-by: Aleksandr Polovtsev <alex.polovtcev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-18895