IGNITE-18953 Add the ability to set attributes for a node to use them for filtering specific nodes #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanpwc
requested changes
Mar 22, 2023
...integrationTest/java/org/apache/ignite/internal/cluster/management/ItClusterManagerTest.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalNode.java
Outdated
Show resolved
Hide resolved
...rationTest/java/org/apache/ignite/internal/cluster/management/raft/ItCmgRaftServiceTest.java
Outdated
Show resolved
Hide resolved
...ache/ignite/internal/cluster/management/configuration/NodeAttributesConfigurationSchema.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalNode.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Constructor. | ||
| * | ||
| * @param clusterNode Represents a node in a cluster.. |
Contributor
There was a problem hiding this comment.
It's either "..." or '.')) And yep both clusterNode and LogicalNode represents a node in a cluster. We should either remove meaningless javadoc or add more definitions, e.g. saying that it's not a cluster, put network topology etc.
Contributor
Author
There was a problem hiding this comment.
e.g. saying that it's not a cluster, put network topology etc.
To be honest, I didn't understand your comment fully, could you please elaborate a bit?
Contributor
There was a problem hiding this comment.
Two points after the "cluster". Minor, won't wait for it. Please fix somewhere aside.
...c/test/java/org/apache/ignite/internal/distributionzones/util/DistributionZonesTestUtil.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/apache/ignite/internal/distributionzones/util/DistributionZonesTestUtil.java
Outdated
Show resolved
Hide resolved
...unner/src/integrationTest/java/org/apache/ignite/internal/compute/ItLogicalTopologyTest.java
Show resolved
Hide resolved
alievmirza
changed the title
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
… filtering specific nodes added (apache#1819)
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Mar 20, 2025
* Add `source.offset.mode` property * `NONE` - do not store CQ watermark in Kafka - no resume on restart * `ALL` - store CQ watermark with every Kafka source record - resume CQ on connector restart * Add `source.offset.fail.mode` property * `FAIL` - fails CQ when stored watermark is too old * `IGNORE` - ignores invalid watermark and starts the connector anyway, potentially missing some updates Additionally: * Add `CONTINUOUS_QUERY_ERR_GROUP` and `WATERMARK_TOO_OLD_ERR` to handle watermark errors by code * Optimize watermark serialization with `watermarkBytes` and `fromBytes` to avoid extra array allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-18953