IGNITE-19119 Prepare org.apache.ignite.internal.storage.index.IndexStorage to built index#1839
IGNITE-19119 Prepare org.apache.ignite.internal.storage.index.IndexStorage to built index#1839tkalkirill merged 11 commits intoapache:mainfrom
Conversation
| * | ||
| * @throws StorageException If failed to get the row ID. | ||
| */ | ||
| @Nullable RowId getNextRowIdToBuild(); |
There was a problem hiding this comment.
All other methods in this class declare throws StorageException explicitly
There was a problem hiding this comment.
But this exception is not checked, there is no need to specify it, documentation is enough.
I can remove it in other methods, but I think we should not change it.
There was a problem hiding this comment.
But this exception is not checked, there is no need to specify it, documentation is enough.
I agree with you, but consistency is more important. So we either add them everywhere or remove them. I think @ibessonov may be against removing them, because he added these throws in the first place.
There was a problem hiding this comment.
From my side - exception in the signature simply makes it more explicit.
StorageException should have been checked, and we wouldn't have this discussion in such case.
There was a problem hiding this comment.
We discussed it personally, decided to remake StorageException into a checked in the future and therefore add it to the signature.
There was a problem hiding this comment.
Please don't do that, checked exceptions suck and should not be used
...a/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java
Show resolved
Hide resolved
...java/org/apache/ignite/internal/storage/pagememory/index/AbstractPageMemoryIndexStorage.java
Outdated
Show resolved
Hide resolved
...s/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbUtils.java
Outdated
Show resolved
Hide resolved
...ory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/meta/IndexMetaKey.java
Outdated
Show resolved
Hide resolved
…orage to built index (apache#1839)
https://issues.apache.org/jira/browse/IGNITE-19119