Skip to content

IGNITE-19143 Fix memory leak in ClientInboundMessageHandler#1852

Merged
ptupitsyn merged 1 commit intoapache:mainfrom
ptupitsyn:ignite-19143
Mar 29, 2023
Merged

IGNITE-19143 Fix memory leak in ClientInboundMessageHandler#1852
ptupitsyn merged 1 commit intoapache:mainfrom
ptupitsyn:ignite-19143

Conversation

@ptupitsyn
Copy link
Contributor

@ptupitsyn ptupitsyn commented Mar 28, 2023

this::onPartitionAssignmentChanged allocates a new delegate object, so removeAssignmentsChangeListener did not work. Store the delegate in a field and use the same object to unsubscribe.

@ptupitsyn ptupitsyn self-assigned this Mar 28, 2023
@ptupitsyn ptupitsyn requested a review from isapego March 28, 2023 12:23
@ptupitsyn ptupitsyn merged commit 54b4317 into apache:main Mar 29, 2023
@ptupitsyn ptupitsyn deleted the ignite-19143 branch March 29, 2023 04:31
lowka pushed a commit to gridgain/apache-ignite-3 that referenced this pull request Apr 19, 2023
)

`this::onPartitionAssignmentChanged` allocates a new delegate object, so `removeAssignmentsChangeListener` did not work. Store the delegate in a field and use the same object to unsubscribe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants