IGNITE-19135 Benchmarks code for puts/reads#1876
Merged
ibessonov merged 8 commits intoapache:mainfrom Apr 25, 2023
Merged
Conversation
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
# Conflicts: # modules/runner/build.gradle
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
kgusakov
suggested changes
Apr 10, 2023
| * Closes resources. | ||
| */ | ||
| @TearDown | ||
| public void tearDow() throws Exception { |
Contributor
There was a problem hiding this comment.
Suggested change
| public void tearDow() throws Exception { | |
| public void tearDown() throws Exception { |
| */ | ||
| @TearDown | ||
| public void tearDow() throws Exception { | ||
| IgniteUtils.closeAll(session/*, statement*/); |
Contributor
There was a problem hiding this comment.
Why statement is commented?
Contributor
Author
There was a problem hiding this comment.
Because it throws UnsupportedOperationException, I need to add a comment
Contributor
|
@ibessonov In general, I think we should run these benchmarks on the nightly run of main only, but not on the every change, what do you think? Benchmarks have big enough time and resource consumption and I suppose this suite will grow up. |
Contributor
Author
|
@kgusakov These benchmarks don't run on TC at all, because they are not part of integration tests. They just exist in the same module. I expect people, who need to benchmark their fix, to do it locally on their own. |
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
kgusakov
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19135