IGNITE-19384 Update deployment units after deploy#2044
Merged
PakhomovAlexander merged 9 commits intoapache:mainfrom May 18, 2023
Merged
IGNITE-19384 Update deployment units after deploy#2044PakhomovAlexander merged 9 commits intoapache:mainfrom
PakhomovAlexander merged 9 commits intoapache:mainfrom
Conversation
Introduce node statuses.
# Conflicts: # modules/cli/src/main/java/org/apache/ignite/internal/cli/core/repl/registry/impl/UnitsRegistryImpl.java
Fix checkstyle
...e-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeployMessagingService.java
Show resolved
Hide resolved
...e-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeployMessagingService.java
Outdated
Show resolved
Hide resolved
| .collect(Collectors.toMap(Map.Entry::getKey, entry -> readContent(entry.getValue()))); | ||
| } catch (DeploymentUnitReadException e) { | ||
| return failedFuture(e); | ||
| } |
Contributor
There was a problem hiding this comment.
I think this try-catch block can be moved to a separate method like readUnitContent
...de-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentManagerImpl.java
Show resolved
Hide resolved
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/UnitMeta.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/ignite/internal/deployunit/metastore/DeploymentUnitMetastoreImpl.java
Show resolved
Hide resolved
...c/main/java/org/apache/ignite/internal/deployunit/metastore/DeploymentUnitMetastoreImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private Condition existsAll(ByteArray key, List<byte[]> keys) { | ||
| Condition result = exists(key); |
Contributor
There was a problem hiding this comment.
This can be inlined. result is not the best name I think.
Contributor
Author
There was a problem hiding this comment.
This is private static method. Why it should be inlined into lyambda?
...nt/src/main/java/org/apache/ignite/internal/deployunit/metastore/UnitsByNodeAccumulator.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Here you've changed the status for node1 with id1 to DEPLOYED but the assertion says UPLOADING. I don't understand why.
Contributor
Author
There was a problem hiding this comment.
DEPLOYED is node status. UPLOADING is cluster status
Fix node deployment status
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/UnitStatus.java
Outdated
Show resolved
Hide resolved
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/UnitStatuses.java
Outdated
Show resolved
Hide resolved
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/UnitStatuses.java
Outdated
Show resolved
Hide resolved
Fix сheckstyle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19384