IGNITE-14841 Use shared distruptor pool for multiple raft group nodes #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanpwc
reviewed
Aug 2, 2021
| */ | ||
| public static boolean bootstrap(final BootstrapOptions opts) throws InterruptedException { | ||
| final NodeImpl node = new NodeImpl(); | ||
| final NodeImpl node = new NodeImpl("unittest", new PeerId("127.0.0.1", 0)); |
Contributor
There was a problem hiding this comment.
Am I right that JRaftUtils isn't a part of test package? If true it's strange to see "unittest" and "new PeerId("127.0.0.1", 0)" here. Is there any sense in bootstrap method in non-test environment? If not, did you consider moving bootstrap to test env?
Contributor
Author
There was a problem hiding this comment.
Rename it to bootstrap.
I do not know to do with the method, and it is need or not in our purposes.
| if (opts.getfSMCallerExecutorDisruptor() == null) { | ||
| opts.setfSMCallerExecutorDisruptor(new StripedDisruptor<FSMCallerImpl.ApplyTask>( | ||
| "JRaft-FSMCaller-Disruptor", | ||
| opts.getRaftOptions().getDisruptorBufferSize(), |
Contributor
There was a problem hiding this comment.
Could you please clarify purposes of each disraptor?
Contributor
Author
There was a problem hiding this comment.
The queue is for process state machine events on the RAFT node.
vldpyatkov
force-pushed
the
ignite-14841
branch
from
2ccbf79 to
81c28db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.