IGNITE-19460 Sql. Implement missed DDL commands with using Catalog #2085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMashenkov
force-pushed
the
ignite-19460
branch
4 times, most recently
from
0185853 to
d29dd53
Compare
korlov42
reviewed
May 29, 2023
Contributor
korlov42
left a comment
korlov42
left a comment
There was a problem hiding this comment.
@AMashenkov, current patch is to big review it throughly. Let's split it on a few (at least separate index-related changes out of column-related ones)
...ner/src/integrationTest/java/org/apache/ignite/internal/sql/internal/InternalSchemaTest.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/NewIndexEntry.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/NewIndexEntry.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/DropIndexEntry.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/DropIndexEntry.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/DropColumnsEntry.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/NewColumnsEntry.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/NewColumnsEntry.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEvent.java
Outdated
Show resolved
Hide resolved
...es/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/IndexDescriptor.java
Outdated
Show resolved
Hide resolved
xtern
reviewed
May 29, 2023
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/ColumnParams.java
Outdated
Show resolved
Hide resolved
korlov42
reviewed
May 31, 2023
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java
Show resolved
Hide resolved
...og/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java
Outdated
Show resolved
Hide resolved
...og/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java
Outdated
Show resolved
Hide resolved
...og/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java
Show resolved
Hide resolved
...les/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CreateIndexParams.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java
Outdated
Show resolved
Hide resolved
# Conflicts: # modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java # modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java # modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEvent.java # modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java # modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerWrapper.java # modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlToCatalogCommandConverter.java
xtern
reviewed
Jun 2, 2023
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManager.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEvent.java
Outdated
Show resolved
Hide resolved
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/events/CatalogEvent.java
Outdated
Show resolved
Hide resolved
...alog/src/main/java/org/apache/ignite/internal/catalog/events/CreateIndexEventParameters.java
Outdated
Show resolved
Hide resolved
...er/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java
Outdated
Show resolved
Hide resolved
...ner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlSynchronousApiTest.java
Outdated
Show resolved
Hide resolved
korlov42
approved these changes
Jun 2, 2023
Contributor
korlov42
left a comment
korlov42
left a comment
There was a problem hiding this comment.
The patch looks good. I highlighted the place that nice to have fixed before merge.
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java
Outdated
Show resolved
Hide resolved
# Conflicts: # modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractTableCommandParams.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19460
Implemented CREATE INDEX, DROP INDEX commands and events.