[IGNITE-19496] Sql. Implement SqlSchemaManager on top of CatalogService. #2100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowka
changed the title
lowka
force-pushed
the
IGNITE-19496
branch
2 times, most recently
from
92d545b to
64c5797
Compare
lowka
changed the title
AMashenkov
reviewed
May 31, 2023
...es/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/TableDescriptor.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
May 31, 2023
...ql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/ImplicitCastsTest.java
Outdated
Show resolved
Hide resolved
lowka
commented
May 31, 2023
...src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/TableScanNodeExecutionTest.java
Outdated
Show resolved
Hide resolved
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Updated PR, changes related to integration of a catalog backed schema manager has been removed. |
AMashenkov
reviewed
Jun 2, 2023
...l-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java
Outdated
Show resolved
Hide resolved
AMashenkov
approved these changes
Jun 2, 2023
lowka
commented
Jun 2, 2023
...l-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java
Outdated
Show resolved
Hide resolved
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteIndex.java
Show resolved
Hide resolved
revert IgniteIndex modifications.
fix tests. fix index comment.
# Conflicts: # modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/NonHistoricSchemas.java
Contributor
Author
|
Resolved conflicts. |
Contributor
Author
|
After discussion with Pavel, I updated sql schema manager to use length field. |
AMashenkov
approved these changes
Jun 6, 2023
AMashenkov
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides implementation of SqlSchemaManager backed by catalog + removes constraints that require primary key columns from TableDescriptor constructor.
Adds Implementation of IgniteTable (
IgniteSchemaTable) that supports only planning related operations (with execution related methods throwing exceptions). Index related methods are moved toIgniteSchemaIndex.