IGNITE-19367 Remove MvPartitionStorage#pollForVacuum#2126
Merged
tkalkirill merged 8 commits intoapache:mainfrom Jun 2, 2023
Merged
IGNITE-19367 Remove MvPartitionStorage#pollForVacuum#2126tkalkirill merged 8 commits intoapache:mainfrom
tkalkirill merged 8 commits intoapache:mainfrom
Conversation
sashapolo
reviewed
Jun 2, 2023
| @Test | ||
| void testConcurrentExecuteBatchGc() { | ||
| assertThat(distributionZoneConfig.dataStorage().gcOnUpdateBatchSize().update(2), willSucceedFast()); | ||
| assertThat(distributionZoneConfig.dataStorage().gcOnUpdateBatchSize().update(4), willSucceedFast()); |
Contributor
Author
There was a problem hiding this comment.
Since tryLock is now used, there may be a situation where we did not delete all after trying to replay the race, so we should increase the size of the batch.
...api/src/testFixtures/java/org/apache/ignite/internal/storage/BaseMvPartitionStorageTest.java
Show resolved
Hide resolved
...orage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/GarbageCollector.java
Outdated
Show resolved
Hide resolved
...les/table/src/main/java/org/apache/ignite/internal/table/distributed/gc/GcUpdateHandler.java
Outdated
Show resolved
Hide resolved
| RowId rowId = gcEntry.getRowId(); | ||
|
|
||
| assert binaryRow != null; | ||
| if (!locker.tryLock(rowId)) { |
Contributor
There was a problem hiding this comment.
Why do we stop if we are unable to lock a row? What should the user do with this information? I think this should be reflected in the javadoc
Contributor
Author
There was a problem hiding this comment.
What to prevent possible deadlocks within a single runConsistently.
Contributor
Author
There was a problem hiding this comment.
Removed this behavior from the description.
...table/src/test/java/org/apache/ignite/internal/table/distributed/gc/GcUpdateHandlerTest.java
Show resolved
Hide resolved
sashapolo
reviewed
Jun 2, 2023
...table/src/test/java/org/apache/ignite/internal/table/distributed/gc/GcUpdateHandlerTest.java
Outdated
Show resolved
Hide resolved
sashapolo
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19367