IGNITE-19630 Convert default value from Column to TableColumnDescriptor#2136
Merged
tkalkirill merged 1 commit intoapache:mainfrom Jun 2, 2023
Merged
IGNITE-19630 Convert default value from Column to TableColumnDescriptor#2136tkalkirill merged 1 commit intoapache:mainfrom
tkalkirill merged 1 commit intoapache:mainfrom
Conversation
tkalkirill
approved these changes
Jun 2, 2023
Contributor
tkalkirill
left a comment
tkalkirill
left a comment
There was a problem hiding this comment.
My offer is optional.
Comment on lines
+113
to
+120
| private static DefaultValue defaultValue(DefaultValueProvider defaultValueProvider) { | ||
| if (defaultValueProvider instanceof FunctionalValueProvider) { | ||
| FunctionalValueProvider functionalProvider = (FunctionalValueProvider) defaultValueProvider; | ||
| return DefaultValue.functionCall(functionalProvider.name()); | ||
| } else { | ||
| return DefaultValue.constant(defaultValueProvider.get()); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| private static DefaultValue defaultValue(DefaultValueProvider defaultValueProvider) { | |
| if (defaultValueProvider instanceof FunctionalValueProvider) { | |
| FunctionalValueProvider functionalProvider = (FunctionalValueProvider) defaultValueProvider; | |
| return DefaultValue.functionCall(functionalProvider.name()); | |
| } else { | |
| return DefaultValue.constant(defaultValueProvider.get()); | |
| } | |
| } | |
| private static DefaultValue defaultValue(DefaultValueProvider defaultValueProvider) { | |
| if (defaultValueProvider instanceof FunctionalValueProvider) { | |
| FunctionalValueProvider functionalProvider = (FunctionalValueProvider) defaultValueProvider; | |
| return DefaultValue.functionCall(functionalProvider.name()); | |
| } | |
| return DefaultValue.constant(defaultValueProvider.get()); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19630