IGNITE-19535 Removed a requirement to have a special constructor for Ignite exceptions #2178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibessonov
reviewed
Jun 13, 2023
| */ | ||
| public class IgniteExceptionUtils { | ||
| /** Private constructor to prohibit creating an instance of utility class. */ | ||
| private IgniteExceptionUtils() { |
Contributor
There was a problem hiding this comment.
I ask this everyone who writes such code.
Have you ever encounter anyone who tried instantiating utility class? I see these constructors as utterly pointless.
Contributor
Author
There was a problem hiding this comment.
Well, it is an interesting question :)
It looks absolutely reasonable to prohibit an action that does not make any sense. On the other hand, it does not break anything and so, this private constructor can be omitted.
modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java
Show resolved
Hide resolved
sanpwc
approved these changes
Jun 15, 2023
…py Ignite exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19535