IGNITE-19500 IndexManager should listen CatalogService events instead of configuration#2254
Merged
Merged
Conversation
…ger to catalog events (apache#2247)
AMashenkov
force-pushed
the
catalog-feature
branch
2 times, most recently
from
2175f4e to
2690ecd
Compare
…ite-19500 # Conflicts: # modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java # modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
AMashenkov
reviewed
Jul 12, 2023
…ite-3 into ignite-19500
AMashenkov
reviewed
Jul 31, 2023
AMashenkov
reviewed
Jul 31, 2023
AMashenkov
reviewed
Jul 31, 2023
AMashenkov
reviewed
Jul 31, 2023
AMashenkov
reviewed
Jul 31, 2023
| await(((TableManager) node.tables()).createTableAsync(schTblAllSql.name(), DEFAULT_ZONE_NAME, tblCh -> | ||
| SchemaConfigurationConverter.convert(schTblAllSql, tblCh) | ||
| )); | ||
| sql(String.format("CREATE TABLE %s(\"%s\" INTEGER PRIMARY KEY, \"TIMESTAMP\" TIMESTAMP(9))", kvTblName, keyCol)); |
Member
There was a problem hiding this comment.
Why do you drop DATETIME column?
Contributor
Author
There was a problem hiding this comment.
There is a nuance here, here I left org.apache.ignite.sql.ColumnType#DATETIME which in SQL has the org.apache.calcite.sql.type.SqlTypeName#TIMESTAMP, but I can’t use org.apache.ignite.sql.ColumnType#TIMESTAMP because in SQL it is type org.apache.calcite.sql.type.SqlTypeName#TIMESTAMP_WITH_LOCAL_TIME_ZONE which does not currently work here is the IGNITE-17376 and IGNITE-19274.
I looked at the mapping in org.apache.ignite.internal.sql.engine.util.TypeUtils#columnType.
Member
There was a problem hiding this comment.
Ok. Let's add these tickets to comment as well, or disable the test with these tickets numbers.
AMashenkov
reviewed
Jul 31, 2023
AMashenkov
reviewed
Jul 31, 2023
rpuch
reviewed
Jul 31, 2023
rpuch
reviewed
Aug 1, 2023
rpuch
approved these changes
Aug 1, 2023
AMashenkov
approved these changes
Aug 1, 2023
tkalkirill
added a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Aug 1, 2023
… of configuration (apache#2254)
tkalkirill
added a commit
that referenced
this pull request
Sep 14, 2023
* IGNITE-19500 IndexManager should listen CatalogService events instead of configuration (#2254) * IGNITE-20102 Fix hanging C#/C++ tests due to IndexManager switch to catalog (#2383) * IGNITE-20236 Get rid of DistributionZonesConfigurationSchema#defaultDataStorage (#2456) * IGNITE-20244 Replace the use of constants from the DistributionZoneManager with constants from CatalogUtils and CatalogService (#2459) * IGNITE-19497 Sql. Switch to SqlSchemaManager implementation on top of CatalogService (#2441) * IGNITE-20215 DistributionZoneRebalanceEngine should listen CatalogService events instead of configuration (#2448) * IGNITE-20114 DistributionZoneManager should listen CatalogService events instead of configuration (#2415) * IGNITE-19499 TableManager should listen CatalogService events instead of configuration (#2500) * IGNITE-20332 Fixed DistributionZoneManager.onUpdateFilter handling. (#2574) * IGNITE-20331 Cleanup the code after switching TableManager to the catalog (#2577) --------- Co-authored-by: amashenkov <andrey.mashenkov@gmail.com> Co-authored-by: Andrew V. Mashenkov <AMashenkov@users.noreply.github.com> Co-authored-by: Sergey Uttsel <uttsel@gmail.com> Co-authored-by: Pavel Pereslegin <xxtern@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19500