Skip to content

Conversation

@alievmirza
Copy link
Contributor

event.expectedTerm = task.getExpectedTerm();
};
switch (this.options.getApplyTaskMode()) {
case Blocking:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if a blocking mode has any use for us. Probably shouldn't be ported at all.
@alievmirza Do you know a single use case ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, it could help us to not fail with overload exception in scenarios like this https://issues.apache.org/jira/browse/IGNITE-19419

Also in the current implementation after overload of disk queue in LogManagerImpl and overload of FSMCallerImpl they enter erroneous state that is never reset, which makes impossible the further work of the component. It was fixed also

Copy link
Contributor

@ascherbakoff ascherbakoff Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is forbidden to use blocking code in Ignite worker threads. The patch adds retries on a busy state, this should be enough. It seems a blocking mode will never be used.

@asfgit asfgit closed this in 606f17f Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants